From: Craig J. A. <and...@ho...> - 2011-01-10 16:45:01
|
> > > "I've also been working on another feature that I'd like to add to the Ancestor report ''Show Siblings of the Center Person.'" > > Is it not possible to merge some others features used by Reinhard on his FamilyTree addon? > http://gramps-addons.svn.sourceforge.net/viewvc/gramps-addons/trunk/contrib/FamilyTree/ > the FamilyTree is nice, but am aiming at a more classical ancestor/descendant reports (with lots of options). It would be good to check/combine his code with mine. Make a better base for the two. Actually, I'll look into that as my reports are left to right ONLY at the moment (I am planning bottom to top for Ancestor and top to bottom for Descendant) and his code may help me/mine improve. > > "The code is done now, but I am making sure it is clean first. May I still include this into Gramps for 3.3?" > > I must say that I did not often use graphical reports ... but I saw that you use others class names. Is it to avoid mistakes with previous user options? I am not sure what you are asking. But for the Descendant reports there are 7 title classes. This is because of polymorphism and it is easier for me to create different titles that have the same code structure, but differ in implementation... Um... I think I am answering the wrong question. Uh, if you mean the class names are the same as in other reports.... This is derived work from the existing reports, to my third party reports, to what is here now. So I am sure that a lot of things carried over... > > "I have not heard anything back about the documentation yet. I know I didn't do that good of a job." > > I will have a look. > > Thank you. > > Jérôme Thank you too! I want to put out a polished product for Gramps and having help is immeasurable. my question still stands: May I still include this into Gramps for 3.3? But as today is maybe the code freeze day I will hold off. Craig A. |