From: Nick H. <nic...@ho...> - 2010-07-10 22:33:37
|
Jerome, Thanks for the feedback. jerome wrote: > Hi, > > I did not have try the patch with last trunk revision ... I will do later. > I guess, it is why code cannot retrieve set_tag function ? > > 516583: ERROR: gramps.py: line 138: Unhandled exception > Traceback (most recent call last): > File "src/gui/views/tags.py", line 256, in <lambda> > return lambda x: func(handle) > File "src/gui/views/tags.py", line 185, in tag > view.add_tag(tag) > File "src/plugins/lib/libpersonview.py", line 434, in add_tag > set_tag(person, tag) > NameError: global name 'set_tag' is not defined > > I intended the patch to be installed against the latest trunk revision. Did you getting an error when installing the patch? I would expect to see the following line near the top of src/plugins/lib/libpersonview.py: from gui.views.tags import set_tag > To set tag seems not to be very important now, as it is a design (way to use) patch, right ? > Yes, the prototype should allow us to evaluate the user interface and also let me try out some design ideas in the code. > First, congratulation, change hightlighted around 20 missing custom attributes with a copy of my primary database. > Now, I know whose were missing. Thanks ! > > Playing with this feature, it sounds like Attribute gramplets but only for custom attributes. > Yes, you could easily modify the Attribute gramplet to be a Tag gramplet. In the prototype, tags are just custom attributes with a value set to an empty string. > To be able to match them into the view gives more possibilties to the user : export data, (un-)tag by group, edition via Menu, managing all custom attributes. That's great ! :) > Un-tag is a good idea. I didn't include any way to remove tags in the prototype. > I also see one big advandage to "real" tags stored into data : no need a database update. > And without custom attributes, we have an empty custom attributes list (no comments for this hight-level demonstration), only the ability for the user to use this feature (or not). > Custom attributes are already exported (only XML file format) and properly managed by Gramps ! :) > > ex : <attribute type="Ascendant Jean YANNE" value=""> > > Primary objects using attributes are : persons, families, events, media. > There is also the data "key/value" on source object (used by census addon). > I guess the key on source's data item could be like the attribute key. > Maybe to be able to display sources with the same key on data item could be useful ? > > Although it would involve less work to store tags as attributes, it is not necessarily the nest solution. Storing the tags as a separate field has some advantages. If we decide to add an extra field we would have to modify the database, allow the tags to be edited in the editors, and include tags in the xml schema. > At glance, only two minor visual issues: > 1. custom attributes list is not sorted by the first letter (alphabetical) on Edition Menu. > It is on Filter Sidebar. > I'll check this. I intended both lists to be alphabetical. > 2. tag icon not on patch > > > I did notice this when I created the patch. You need to create a file called gramps-tags.png and place it in src/images. I just googled for "free tags icon" and found a suitable 32x32 png file. We will need to get someone to design one for Gramps or find one with a suitable licence. Icon design is not my area of expertise - someone else would be better doing this. > Good work and nice result! > > Thank you. I think that it is a good start. I'm not too sure how to take this further. Perhaps we need Brian or Benny to have a look at this stage. If I have time, I'll have a look at adding colours to the rows which are tagged. Regards, Nick. > Regards, > > Jérôme > > --- En date de : Ven 9.7.10, Nick Hall <nic...@ho...> a écrit : > > >> De: Nick Hall <nic...@ho...> >> Objet: [Gramps-devel] Prototype for tagging functionality (GEPS 011) >> À: "Gramps developers" <gra...@li...> >> Date: Vendredi 9 juillet 2010, 18h35 >> Hi, >> >> I have written a prototype to add tagging functionality to >> Gramps. >> >> The download and a proposed design can be found in GEPS >> 011: >> >> http://gramps-project.org/wiki/index.php?title=GEPS_011:_Tagging >> >> The prototype uses attributes to store the data and allows >> the user to >> tag a selection of people, filter on a tag and display tags >> in a column. >> >> Let me know what you think. >> >> Regards, >> >> >> Nick. >> >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by Sprint >> What will you do first with EVO, the first 4G phone? >> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first >> _______________________________________________ >> Gramps-devel mailing list >> Gra...@li... >> https://lists.sourceforge.net/lists/listinfo/gramps-devel >> >> > > > > > > |