[Gramps-devel] Re : Prototype for tagging functionality (GEPS 011)

[jerome <rom...@ya...>]

Hi,

I did not have try the patch with last trunk revision ... I will do later.
I guess, it is why code cannot retrieve set_tag function ?

516583: ERROR: gramps.py: line 138: Unhandled exception
Traceback (most recent call last):
  File "src/gui/views/tags.py", line 256, in <lambda>
    return lambda x: func(handle)
  File "src/gui/views/tags.py", line 185, in tag
    view.add_tag(tag)
  File "src/plugins/lib/libpersonview.py", line 434, in add_tag
    set_tag(person, tag)
NameError: global name 'set_tag' is not defined

To set tag seems not to be very important now, as it is a design (way to use) patch, right ?

First, congratulation, change hightlighted around 20 missing custom attributes with a copy of my primary database. 
Now, I know whose were missing. Thanks !

Playing with this feature, it sounds like Attribute gramplets but only for custom attributes.
To be able to match them into the view gives more possibilties to the user : export data, (un-)tag by group, edition via Menu, managing all custom attributes. That's great ! :)

I also see one big advandage to "real" tags stored into data : no need a database update.
And without custom attributes, we have an empty custom attributes list (no comments for this hight-level demonstration), only the ability for the user to use this feature (or not).
Custom attributes are already exported (only XML file format) and properly managed by Gramps ! :)

ex : <attribute type="Ascendant Jean YANNE" value="">

Primary objects using attributes are : persons, families, events, media.
There is also the data "key/value" on source object (used by census addon).
I guess the key on source's data item could be like the attribute key.
Maybe to be able to display sources with the same key on data item could be useful ?

At glance, only two minor visual issues: 
1. custom attributes list is not sorted by the first letter (alphabetical) on Edition Menu. 
It is on Filter Sidebar.
2. tag icon not on patch


Good work and nice result! 


Regards,

Jérôme

--- En date de : Ven 9.7.10, Nick Hall <nic...@ho...> a écrit :

> De: Nick Hall <nic...@ho...>
> Objet: [Gramps-devel] Prototype for tagging functionality (GEPS 011)
> À: "Gramps developers" <gra...@li...>
> Date: Vendredi 9 juillet 2010, 18h35
> Hi,
> 
> I have written a prototype to add tagging functionality to
> Gramps.
> 
> The download and a proposed design can be found in GEPS
> 011:
> 
> http://gramps-project.org/wiki/index.php?title=GEPS_011:_Tagging
> 
> The prototype uses attributes to store the data and allows
> the user to 
> tag a selection of people, filter on a tag and display tags
> in a column.
> 
> Let me know what you think.
> 
> Regards,
> 
> 
> Nick.
> 
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>