Re: [Gramps-devel] Admin decision needed!

[Benny M. <ben...@gm...>]

2010/6/5 Rob Healey <rob...@gm...>

> Dear Benny:
>
> Since the decision has been made to look into adding place maps into
> NarrativeWeb, I would love to make a proposal for javascript files...
>
> I know that gramps is predominately a python program, but we are finding
> ourselves in the need for some javascript files too!  I know that Doug has
> with Gramps-Connect.  I also need some javascript files for working with
> google/ OpenLayers place maps...
>
> I would like to create a directory structure for this purpose:
> trunk
>     --> src
>         --> data
>             --> javascript
>                 --> mapstraction
>

Javascript is code, so it should be with the code that uses it. Only if it
is a sort of data should it be in the data directory. If you talk about
javascript for a plugin, it should be possible to install it with plugin
code, so the javascript should be in the same dir as the plugin code.

Mapstraction is a special thing, it is a piece of code of other people we
redistribute so as to be sure we are using a single version of it.

For adding place maps in NarWeb, as said before, we are starting to have
_too_ many options in narweb, we should move to a sort of plugin based
NarWeb. Then this map data would be a plugin for nar web, and people can set
the options of it in the nar web dialog, eg, a sidepane with all installed
narweb plugins, and selecting it shows to the right the options for this
plugin.

As I said many times before, it is not because a user asks something that we
jump up and start doing it. The Gramps code must remain manageable. We still
have many narweb bugs in gramps32 if I'm not mistaken. The big codebase of
nar web is to blame for this. If we cannot make narweb better maintainable,
we should not keep adding things.

About the data directory, in my eyes it should only contain data that a
program uses to work with (like authors, tips, ...), and the other elements
should move to their own directory (so a src/css, and should be have pure
javascript, src/js). Real code on the other hand should be grouped by
functionality, so I rather see a
src/plugins/web/narweb with the plugin, css for the plugin and javascript,
all together.
Any other ideas about this?


> The only things that need to be done:
> 1) move src/mapstraction --> src/ata/javascript/mapstraction
> 2) create a const.JAVASCRIPT_DIR variable in src/const.py
>
> If this is agreeable, then I will commit my local changes?  If anyone has
> any comments, feelings, objections, please let's discuss it...
>

So no, I do not agree. Nar web is a plugin, and installation must be
possible in it's own self-contained directory. If we use a
const.JAVASCRIPT_DIR, one might have one plugin overwriting data of another.

Benny

>
> Sincerely yours,
> Rob G. Healey
>
>
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit.  See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>