Re: [Gramps-devel] [Gramps 3.2.x 0003761]: Error when editing family event

[Benny M. <ben...@gm...>]

2010/3/26 Benny Malengier <ben...@gm...>

>
>
> 2010/3/25 Alain Aupeix <ala...@wa...>
>
>> Benny Malengier a écrit :
>> >
>> >
>> > 2010/3/25 Alain Aupeix <ala...@wa...
>> > <mailto:ala...@wa...>>
>> >
>> >     Benny Malengier a écrit :
>> >     >
>> >
>> > So, try it Alain, in editfamily.py go to line 884 and change
>> >
>> >                 EditPerson(self.dbstate, self.uistate,
>> >                            self.track, person)
>> >
>> > into
>> >
>> >                 EditPerson(self.dbstate, self.uistate,
>> >                            [], person)
>> >
>> > and write back with what you think of that.
>> That's ok, person window is now back and family has focus and is on top.
>> > That will give you the behavior you want. You should do the same in
>> > the other EditPerson calls in this file (eg on child edit in the child
>> > list).
>> I have edited  :
>>
>> add_button_clicked()
>> edit_child_button_clicked()
>> add_mother_clicked()
>> add_father_clicked()
>> editperson()
>>
>> is-it right ?
>>
>
> Sounds right. As long as they do not use a callback function on close, it
> should work. It might be that add_mother/father have a callback to update
> the family when the new person is finished...., you should check. It will
> crash if you close the family before the person is added (as at the end,
> save of person also adds the person as father to the family which is no
> longer present. It depends on how it is coded. Eg, adding an event is via
> eventref, and should always have a track, and aperson/family current on
> which it works..
>

Thinking about this, you should only do it for the edit buttons, not the
add. On add there are no family events yet anyway, and at end of add, the
person has to be added to a family, so having the window close if the family
window closes looks like the correct action to me.

Benny

>
> Benny
>
>
>> A+
>>
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Download Intel&#174; Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> Gramps-devel mailing list
>> Gra...@li...
>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>
>
>