Re: [Gramps-devel] flat person view

[Benny M. <ben...@gm...>]

2010/2/3 Nick Hall <nic...@ho...>:
> Benny,
>
> When I fixed the last bug I noticed that the place views and person views
> have different naming conventions.
>
> We have:
>
> src/plugins/lib/libpersonview.py
> src/plugins/view/personlistview.py
> src/plugins/view/persontreeview.py
>
> src/gui/view/placebaseview.py   -   should we move to plugins/lib ?
> src/plugins/view/placeview.py   -   should we rename to placelistview ?
> src/plugins/view/placetreeview.py
>
> src/gui/views/treemodels/placebasemodel.py
> src/gui/views/treemodels/placemodel.py   -   should we rename to
> placelistmodel ?
> src/gui/views/treemodels/placetreemodel.py
>
> src/gui/views/treemodels/peoplemodel.py   -   the place models are in 3
> files.
>
> Also I notice that we have src/gui/views but src/plugins/view should we
> settle on either singular or plural for directory name?


I already moved baseplaceview to plugins/lib earlier today.
Feel free to change the names to a consistent naming, and to reduce
the 3 models to one file.

Benny

> Regards,
>
> Nick.
>
>
> Benny Malengier wrote:
>>
>> 2010/2/3 Gerald Britton <ger...@gm...>:
>>
>>>
>>> Looks nice!  Some nits:
>>>
>>> 1. The toggle-buttons are reversed are opposite those for places.
>>> That is in person view, the buttons are:
>>>
>>> People (which is the tree view) People list
>>>
>>> whereas in Places we have:
>>>
>>> Places (the flat view) and Tree
>>>
>>> Just as a matter of polish, I feel that these should be in the same
>>> order (don't care which) and that the mouse-hover names should have
>>> some consistency.
>>>
>>
>> Obviously, I aimed at having the first view the one users are used to.
>> We are missing a piece in the ini file: what is the view in a category
>> that was last open. I think that should be added first, before the
>> order is made consistent between place and people. Then we can have
>> gramps open up by default on the people treeview, even if it is the
>> second view. I see if I have time for this.
>>
>>
>>>
>>> 2.I notice that in the corresponding View menu for each type, we have
>>> People View, People List View and Place, Place Tree View.  Two things
>>> about that:
>>>
>>> a. The word "View" is redundant here, since we're in the "View" menu.
>>> Should that word be removed?
>>>
>>
>> Yes, go ahead and see if it looks ok.
>>
>>
>>>
>>> b  The order of the two types of view (list vs tree) is different
>>> between people and places.  Even  worse, the Ctrl-1 in People view
>>> brings up a tree view but in Place view it brings up a list view.  The
>>> order and labels might look better if they are consistent with each
>>> other.
>>>
>>
>> This feeds back to point 1
>>
>>
>>>
>>> 3.Lastly the mouse-hover tips are also inconsistent between People and
>>> Places.
>>>
>>
>> Please, fix whatever you see. These are the kind of annoying things
>> (papercuts in ubuntu speak) that only get fixed if you do it when you
>> see them.
>>
>> Benny
>>
>>
>>>
>>> On Wed, Feb 3, 2010 at 8:42 AM, Benny Malengier
>>> <ben...@gm...> wrote:
>>>
>>>>
>>>> Hi,
>>>>
>>>> Trunk now contains a flat person view, handy if you change column
>>>> order and then sort or filter, to see people with different names
>>>> together. Give it a try.
>>>>
>>>> Nick, I'd like to have this view in sync with tree person view to set
>>>> active person, but have not looked at the new code you added to do
>>>> that. Would you have time to set this up correctly, so that I can
>>>> avoid looking at the API you wrote for that ?
>>>>
>>>> Benny
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> The Planet: dedicated and managed hosting, cloud storage, colocation
>>>> Stay online with enterprise data centers and the best network in the
>>>> business
>>>> Choose flexible plans and management services without long-term
>>>> contracts
>>>> Personal 24x7 support from experience hosting pros just a phone call
>>>> away.
>>>> http://p.sf.net/sfu/theplanet-com
>>>> _______________________________________________
>>>> Gramps-devel mailing list
>>>> Gra...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>
>>>>
>>>
>>> --
>>> Gerald Britton
>>>
>>>
>>
>>
>>
>