From: Gerald B. <ger...@gm...> - 2009-12-11 14:08:54
|
I wonder about the treeview export of people. Can it be more than two-levels on the name column? Or is it just Family name in the first column and individual name in the second? In that case, the export view could simply insert a "Family" column header or something like that in front of the "Name" column. On Fri, Dec 11, 2009 at 9:03 AM, Doug Blank <dou...@gm...> wrote: > On Fri, Dec 11, 2009 at 8:28 AM, Benny Malengier > <ben...@gm...> wrote: >> 2009/12/11 Doug Blank <dou...@gm...>: >>> On Fri, Dec 11, 2009 at 3:33 AM, Benny Malengier >>> <ben...@gm...> wrote: >>>> 2009/12/11 Doug Blank <dou...@gm...>: >>>>> On Thu, Dec 10, 2009 at 5:00 PM, Doug Blank <dou...@gm...> wrote: >>>>>> On Thu, Dec 10, 2009 at 4:13 PM, Gerald Britton >>>>>> <ger...@gm...> wrote: >>>>>>> Hi. I just committed revision 13752 with some little performance >>>>>>> tweaks (and a couple of spelling corrections in the comments) in >>>>>>> listview.py. While testing, I noticed that, if you do an export view >>>>>>> while in treeview mode, the headings in the CSV file produced don't >>>>>>> match the data, particularly because the Family name is in column A >>>>>>> but the full name is in column B. (I attached an example). Thinking >>>>>>> it was my mod, I backed it out, but got the same results. So I think >>>>>>> that there is some problem here, but I'm not sure just what it is. >>>>>> >>>>>> Part of those changes require getting the columns (and eventually, >>>>>> widths) from config rather than the database. I suspect that the CSV >>>>>> code may still be accessing the DB for the columns. I'll take a look >>>>>> tonight, if no one beats me to it. >>>>> >>>>> No that wasn't it... it looks like this is dumping the CSV exactly >>>>> like the screen shows: >>>>> >>>>> Surname1,,,,,, >>>>> ,"Surname1, Given1",,,,, >>>>> ,"Surname1, Given2",,,,, >>>>> Surname2,,,,,, >>>>> ,"Surname2, Given1",,,,, >>>>> ,"Surname2, Given2",,,,, >>>>> >>>>> Not sure when this would have been broken... >>>> >>>> The thing to know is, is it fixed now :-) >>>> >>>> I suppose it got broken when the listview was rewritten. >>> >>> Sorry, I see I wasn't clear. No, I didn't fix it... I was trying to >>> see how it worked before, and couldn't find it. Is it that it never >>> worked, or is it that the code is someplace else? >> >> The changes of Nick means the code for cvs export work on a totally >> different basis, so I would think it works in 3.1 but not in trunk on >> the new classes on treeviews > > Ok, I think I see. Nick has written the export to work as it does. > That is, it looks like it was designed to output the tree, when the > tree view is active. That gives the output as shown above. (Does that > explain the original data, Gerald?) Arguably, this might be useful in > a spreadsheet, but it isn't strictly just cols of data now... it has > the tree division rows interspersed. > > Perhaps the right thing to do is leave it as it is, and provide a > means to switch the View to a flat model. I would actually prefer that > view sometimes. This might suggest that for tree views, there is an > option to switch back and forth. Currently, flat and tree views are > completely different views. (I suspect because to switch back and > forth is expensive?) Otherwise, we need to have a flat person view, > and export that. > > -Doug > >> Benny >> >>> >>> -Doug >>> >>>> Benny >>> >> > -- Gerald Britton |