From: <pet...@te...> - 2009-12-04 14:44:54
|
Folks, I'm not at home now, so I can't do anything. Will be back on Sunday afternoon. /Peter >----Ursprungligt meddelande---- >Från: ben...@gm... >Datum: 2009-12-04 09:47 >Till: "Peter Landgren"<pet...@te...> >Kopia: "Gramps Development List"<gra...@li...> >Ärende: Re: [Gramps-devel] Re : preparing for 3.1.3 > >Peter, I now remember what this was about. >Can you fix this today in the Scratchpad code? You probably still have >your testcase. > >> #String must be unicode for truncation to work for non ascii characters >> - note = unicode(note) >> note = value.get().replace('\n', ' ') >> + note = unicode(note) > >I think should be correct, no? It wouds be better if the comment says: > #String must be unicode for slicing to work for non ascii characters >and still obtain unicode > >Benny > >2009/12/4 jerome <rom...@ya...>: >>> Jerome, do your patch with value for now. >> >> I thought it was the right thing to do (keep Peter's improvement and use after the assignment), but I didn't test it ... >> >> 16663: ERROR: gramps.py: line 160: Unhandled exception >> Traceback (most recent call last): >> File "src/ScratchPad.py", line 1137, in object_drag_data_received >> o = wrapper_class(self.dbstate,sel_data) >> File "src/ScratchPad.py", line 328, in __init__ >> note = value.get().replace('\n', ' ') >> AttributeError: 'unicode' object has no attribute 'get' >> >> value = self._db.get_note_from_handle(handle) >> >> >> #String must be unicode for truncation to work for non ascii characters >> - note = unicode(note) >> note = value.get().replace('\n', ' ') >> + note = unicode(note) > >Yes, just revert to the old >> >> is working but looking at the comment I suppose it makes no real sense ! >> >> >> >> --- En date de : Jeu 3.12.09, Benny Malengier <ben...@gm...> a écrit : >> >>> De: Benny Malengier <ben...@gm...> >>> Objet: Re: [Gramps-devel] Re : preparing for 3.1.3 >>> À: "jerome" <rom...@ya...>, "Peter Landgren" <pet...@te...> >>> Cc: "Gramps Development List" <gra...@li...> >>> Date: Jeudi 3 Décembre 2009, 22h12 >>> Yes, bug introduced here: >>> http://gramps.svn.sourceforge.net/viewvc/gramps/branches/maintenance/gramps31/src/ScratchPad.py?view=diff&r1=13168&r2=13169 >>> >>> Peter, as you introduced this, you remember why? As said in >>> other >>> parts, notes should already be unicode, so no need to >>> convert them. I >>> would think these changed lines may be removed. They don't >>> harm >>> however. >>> >>> Jerome, do your patch with value for now. >>> >>> Benny >>> >>> 2009/12/3 jerome <rom...@ya...>: >>> > or should be something like : >>> > >>> > #String must be unicode for truncation to work for non >>> ascii characters >>> > - note = unicode(note) >>> > + value = unicode(value) >>> > note = value.get().replace('\n', ' ') >>> > >>> > >>> > --- En date de : Jeu 3.12.09, jerome <rom...@ya...> >>> a écrit : >>> > >>> >> De: jerome <rom...@ya...> >>> >> Objet: Re: [Gramps-devel] Re : preparing for >>> 3.1.3 >>> >> À: "Benny Malengier" <ben...@gm...> >>> >> Cc: "Gramps Development List" <gra...@li...> >>> >> Date: Jeudi 3 Décembre 2009, 18h44 >>> >> /!\ there is an unfixed bug/crash on >>> >> 3.1.3-SVN : >>> >> >>> >> 116251: ERROR: gramps.py: line 160: Unhandled >>> exception >>> >> Traceback (most recent call last): >>> >> File "src/ScratchPad.py", line 1137, in >>> >> object_drag_data_received >>> >> o = wrapper_class(self.dbstate,sel_data) >>> >> File "src/ScratchPad.py", line 327, in >>> __init__ >>> >> note = unicode(note) >>> >> UnboundLocalError: local variable 'note' >>> referenced before >>> >> assignment >>> >> >>> >> patch should be easy : >>> >> >>> >> #String must be unicode for >>> >> truncation to work for non ascii characters >>> >> - note = unicode(note) >>> >> note = >>> >> value.get().replace('\n', ' ') >>> >> + note = unicode(note) >>> >> >>> >> To reproduce it : >>> >> >>> >> 1. Go on Note View >>> >> 2. Try to drag and drop a note oject reference >>> from >>> >> NoteView to clipboard >>> >> >>> >> >>> >> Should I commit change ? >>> >> >>> >> >>> >> >>> >> --- En date de : Jeu 3.12.09, Jérôme <rom...@ya...> >>> >> a écrit : >>> >> >>> >> > De: Jérôme <rom...@ya...> >>> >> > Objet: Re: [Gramps-devel] Re : preparing for >>> 3.1.3 >>> >> > À: "Benny Malengier" <ben...@gm...> >>> >> > Cc: "Gramps Development List" <gra...@li...> >>> >> > Date: Jeudi 3 Décembre 2009, 17h28 >>> >> > Benny, >>> >> > >>> >> > >>> 2. On source reference >>> (repository): >>> >> > >>> 2 CALN >>> >> > >>> 3 MEDI Book >>> >> > >>> will be a custom translated >>> media type >>> >> on >>> >> > export >>> >> > >>> 2 CALN >>> >> > >>> 3 MEDI Livre >>> >> > >>> >>> >> > >>> I suppose there is no error >>> because I do >>> >> not >>> >> > loose data, but it is strange ! >>> >> > >> >>> >> > >> Ok, I'll look at that, make a bug >>> ticket (or >>> >> > reopen the previous one. >>> >> > >> The old code ignored MEDI tag, I >>> suppose the >>> >> new >>> >> > code will write it >>> >> > >> out but not in English, it should be >>> easy to >>> >> adapt >>> >> > the writegedcom for >>> >> > >> this, other types already write out >>> the >>> >> english >>> >> > version (probably). Or >>> >> > >> are other types also written out in >>> French? >>> >> It >>> >> > would make some sense, >>> >> > >> GEDCOM programs need not know that >>> Book is >>> >> Livre >>> >> > >>> >> > Looks like not a bug ... >>> >> > I used Gramps without translations ($ python >>> >> > src/gramps.py), and this >>> >> > was already present on 3.1.2. There is no >>> regression >>> >> for >>> >> > this on next >>> >> > release. >>> >> > >>> >> > http://www.gramps-project.org/bugs/changelog_page.php?version_id=15 >>> >> > http://www.gramps-project.org/bugs/view.php?id=3374>>> >> > >>> >> > Code writes value (not tag) in english if you >>> are >>> >> using >>> >> > Gramps in >>> >> > English and translated value into french if >>> you are >>> >> using >>> >> > Gramps in >>> >> > French ! >>> >> > >>> >> > On my 'localized' Gedcom, I get : >>> >> > >>> >> > 1 EVEN >>> >> > 2 TYPE Mariage >>> >> > 1 EVEN >>> >> > 2 TYPE Élection >>> >> > 1 EVEN >>> >> > 2 TYPE Résidence >>> >> > 2 CALN >>> >> > 3 MEDI Livre >>> >> > >>> >> > which sounds correct with this custom data >>> and after >>> >> > looking at the >>> >> > Gedcom header : >>> >> > >>> >> > 1 GEDC >>> >> > 2 VERS 5.5 >>> >> > 2 FORM LINEAGE-LINKED >>> >> > 1 CHAR UTF-8 >>> >> > 1 LANG French >>> >> > >>> >> > TAG do not use non-ASCII characters and >>> values are >>> >> custom >>> >> > data. >>> >> > So, I suppose that's not a bug ! >>> >> > >>> >> > > Or are other types also written out in >>> French? >>> >> > >>> >> > yes it is coherent, only custom or Gramps' >>> types (not >>> >> on >>> >> > Gedcom spec) >>> >> > >>> >> > This kind of thing must be surely forget by >>> the many >>> >> tests >>> >> > which check >>> >> > Gedcom support... They look at custom tag >>> (_CUSTOM) >>> >> but not >>> >> > on values >>> >> > used into the program. >>> >> > >>> >> > It's really nice to have this international >>> support ! >>> >> :) >>> >> > (I say this now but maybe it was me who has >>> grumbled >>> >> at the >>> >> > time and I >>> >> > do not remember !!!) >>> >> > >>> >> > >>> >> > Thanks ! >>> >> > >>> >> > Jérôme >>> >> > >>> >> > >>> >> > >>> >> > >>> >> > >>> >> > Benny Malengier a écrit : >>> >> > > 2009/11/24 jerome <rom...@ya...>: >>> >> > >>> Jerome, your mail is a bit >>> confusing. >>> >> > >> Sorry. I am testing Gedcom >>> management >>> >> changes. >>> >> > >> First, I have tried to export a >>> database >>> >> (Family >>> >> > Tree) to Gedcom format, but a dialog pops-up >>> something >>> >> like >>> >> > "Gramps cannot write /tmp/..." during write >>> person >>> >> process. >>> >> > Gedcom was not properly generated and I ran >>> repair DB >>> >> tools >>> >> > on my opened Family Tree. Then no more >>> message and >>> >> > Gramps-3.1.3 has generated a complete >>> Gedcom. >>> >> > >> >>> >> > >> Looking at diff between the first >>> one and >>> >> the >>> >> > second one. >>> >> > >> I suppose the problem was just >>> "around" >>> >> CHANGE >>> >> > TIME (as I know this has been improved on >>> 3.1.3) and >>> >> lines >>> >> > "not written" on the broken gedcom could be >>> : >>> >> > >> 1 CHAN >>> >> > >> 2 DATE 24 NOV 2009 >>> >> > >> 3 TIME 14:29:13 >>> >> > >> >>> >> > >> Sorry, I cannot very well explain >>> this :( >>> >> > >> I suppose Gramps was not able to >>> write 1 >>> >> CHAN, but >>> >> > I cannot say : "Gramps is not able to write >>> this", >>> >> because >>> >> > process freeze, no error or bug report >>> dialog, just >>> >> Gedcom >>> >> > was not complete. >>> >> > >> >>> >> > >>> because old gramps wrote out >>> french >>> >> dates? >>> >> > >> Do you think this could be an OS >>> issue ? >>> >> python >>> >> > time module ? >>> >> > > >>> >> > > No, it should work ok, the old code was >>> >> completely >>> >> > ignoring CHAN >>> >> > > group, the new code parses it correctly, >>> and it >>> >> is >>> >> > written out >>> >> > > correctly. >>> >> > >>> For the second issue, is this a >>> >> regression? >>> >> > That is could Gramps 3.1.2 read >>> >> > >> I will try to test it. >>> >> > >> >>> >> > >> But seems there is still many >>> problems with >>> >> Gedcom >>> >> > management ... >>> >> > >> >>> >> > >> I am loosing some data by making a >>> diff >>> >> between : >>> >> > >> a Gedcom generated by Gramps and a >>> new one, >>> >> > imported into a new Family Tree then >>> exported. >>> >> > >> >>> >> > >> 1. dates with calendar, like : >>> >> > >> 2 DATE @#DFRENCH R@ 24 VEND 12 >>> >> > >> are not properly imported by >>> Gramps-3.1.3 and >>> >> will >>> >> > return a textual date : >>> >> > >> 2 DATE 24 VEND 12 >>> >> > > >>> >> > > This should have been like this in >>> 3.1.2, it >>> >> means the >>> >> > Date module >>> >> > > that reads it cannot read the @, make a >>> bug >>> >> ticket, >>> >> > but I do not thing >>> >> > > it is a regression. >>> >> > >> 2. On source reference >>> (repository): >>> >> > >> 2 CALN >>> >> > >> 3 MEDI Book >>> >> > >> will be a custom translated media >>> type on >>> >> export >>> >> > >> 2 CALN >>> >> > >> 3 MEDI Livre >>> >> > >> >>> >> > >> I suppose there is no error because >>> I do not >>> >> loose >>> >> > data, but it is strange ! >>> >> > > >>> >> > > Ok, I'll look at that, make a bug ticket >>> (or >>> >> reopen >>> >> > the previous one. >>> >> > > The old code ignored MEDI tag, I suppose >>> the new >>> >> code >>> >> > will write it >>> >> > > out but not in English, it should be >>> easy to >>> >> adapt the >>> >> > writegedcom for >>> >> > > this, other types already write out the >>> english >>> >> > version (probably). Or >>> >> > > are other types also written out in >>> French? It >>> >> would >>> >> > make some sense, >>> >> > > GEDCOM programs need not know that Book >>> is Livre >>> >> > > >>> >> > >> 3. References on Media Objects are >>> ignored >>> >> on >>> >> > export >>> >> > >> I started with 662 references into >>> my Family >>> >> Tree >>> >> > and after a Gedcom import into a new Family >>> Tree, I >>> >> kept 18, >>> >> > which was not media object, only urls on >>> person object >>> >> !!!) >>> >> > >> >>> >> > >> I do not see any problem yet on >>> Gramps XML >>> >> > management, and maybe some of this issues has >>> been >>> >> already >>> >> > reported. I remember something like "Gedcom >>> generated >>> >> by >>> >> > Gramps imported into Gramps". >>> >> > >> >>> >> > >> I suppose "references on Media >>> Objects" and >>> >> the "1 >>> >> > OBJE >>> >> > >> 2 FORM" (url on person) are >>> related. >>> >> > > >>> >> > > This is the first I hear about this. >>> >> > > I do not like coding in GEDCOM, I do not >>> use it >>> >> !!! >>> >> > > >>> >> > > Benny >>> >> > > >>> >> > >> >>> >> > >> I will look at Gedcom regression. >>> >> > >> >>> >> > >> >>> >> > >> Jérôme >>> >> > >> >>> >> > >> >>> >> > >> --- En date de : Mar 24.11.09, >>> Benny >>> >> Malengier >>> >> > <ben...@gm...> >>> >> > a écrit : >>> >> > >> >>> >> > >>> De: Benny Malengier <ben...@gm...> >>> >> > >>> Objet: Re: Re : preparing for >>> 3.1.3 >>> >> > >>> À: "jerome" <rom...@ya...> >>> >> > >>> Cc: "Gramps Development List" >>> <gra...@li...>, >>> >> > "Stéphane Charette" <ste...@gm...> >>> >> > >>> Date: Mardi 24 Novembre 2009, >>> 15h24 >>> >> > >>> Jerome, your mail is a bit >>> >> > >>> confusing. >>> >> > >>> >>> >> > >>> Are you saying the old gedcom >>> crashes now >>> >> on >>> >> > import because >>> >> > >>> old gramps >>> >> > >>> wrote out french dates? Or is >>> there no >>> >> problem >>> >> > (I see no >>> >> > >>> crash report >>> >> > >>> in this mail) >>> >> > >>> >>> >> > >>> For the second issue, is this a >>> >> regression? >>> >> > That is could >>> >> > >>> Gramps 3.1.2 read >>> >> > >>> >>> >> > >>>> 1 OBJE >>> >> > >>>> 2 FORM URL >>> >> > >>>> 2 FILE http://www.festival-mozart.com/compositeurs/schmitt.htm >>> >> > >>> Benny >>> >> > >>> >>> >> > >>> 2009/11/24 jerome <rom...@ya...>: >>> >> > >>>>> so we can prepare for >>> 3.1.3. >>> >> Could >>> >> > >>>>> everyone test perhaps a >>> GEDCOM >>> >> and an >>> >> > XML export >>> >> > >>> of their >>> >> > >>>>> data >>> >> > >>>>> (filtered somehow), and >>> then >>> >> import >>> >> > again in an >>> >> > >>> empty tree. >>> >> > >>>>> The last >>> >> > >>>>> things changes are >>> related to >>> >> that, >>> >> > and GEDCOM >>> >> > >>> changes are >>> >> > >>>>> sensitive. >>> >> > >>>> I have started to test >>> import from >>> >> > Gramps-3.1.3 to >>> >> > >>> Gramps-3.1.3 >>> >> > >>>> (Ubuntu 9.04, python 2.6) >>> >> > >>>> >>> >> > >>>> ///// 1 warning during >>> Gramps >>> >> > session /////// >>> >> > >>>> (gramps.py:4609): CRITICAL >>> **: >>> >> > >>> murrine_style_draw_focus: >>> assertion >>> >> `height >>> >> > >= -1' >>> >> > >>> failed >>> >> > >>>> ///// 1 problem on GEDCOM >>> export >>> >> /////// >>> >> > >>>> >>> >> > >>>> "Cannot write file ..." >>> message on >>> >> dialog >>> >> > (on write >>> >> > >>> persons) >>> >> > >>>> Fixed after running rebuild >>> 2nd >>> >> indices >>> >> > and "Check >>> >> > >>> & Repair" tools. (no problem >>> with >>> >> Gramps >>> >> > XML format) >>> >> > >>>> Re-test is OK. >>> >> > >>>> Pass without error by using >>> : >>> >> > >>>> >>> >> > >>>> 1 CHAN >>> >> > >>>> 2 DATE 24 NOV 2009 >>> >> > >>>> 3 TIME 14:29:13 >>> >> > >>>> >>> >> > >>>> Looks like first test has >>> blocked >>> >> just >>> >> > before "change >>> >> > >>> time" on person object ! >>> >> > >>>> /!\ I used my testing >>> database >>> >> (generated >>> >> > before new >>> >> > >>> time management on Gedcom >>> >> > >>>> ///// problem on GEDCOM >>> import >>> >> /////// >>> >> > >>>> >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer http://www.geneanet.org/contact.php3?source=bouly78 >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer http://www.geneanet.org/rgentner>>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer http://gw1.geneanet.org/index.php3?b=henriks >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer http://gw1.geneanet.org/index.php3?b=gengiskhan >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer http://gw1.geneanet.org/index.php3?b=myriague >>> >> > >>>> WARNING .GedcomImport: >>> Impossible >>> >> > d'importer http://www.festival-mozart.com/compositeurs/schmitt.htm >>> >> > >>>> >>> >> > >>>> => Cannot import url >>> >> > >>>> >>> >> > >>>> was generated by >>> Gramps-3.1.3 : >>> >> > >>>> >>> >> > >>>> 0 @I1802@ INDI >>> >> > >>>> 1 NAME Florent /SCHMITT/ >>> >> > >>>> 2 GIVN Florent >>> >> > >>>> 2 SURN SCHMITT >>> >> > >>>> 1 SEX M >>> >> > >>>> 1 OBJE >>> >> > >>>> 2 FORM URL >>> >> > >>>> 2 FILE http://www.festival-mozart.com/compositeurs/schmitt.htm >>> >> > >>>> >>> >> > >>>> Now, I will try to see any >>> diff on >>> >> data >>> >> > (Gedcom, >>> >> > >>> Gramps XML) >>> >> > >>>> >>> >> > >>>> >>> >> > >>>> Jérôme R. >>> >> > >>>> >>> >> > >>>> >>> >> > >>>> --- En date de : Dim >>> 22.11.09, Benny >>> >> > Malengier <ben...@gm...> >>> >> > >>> a écrit : >>> >> > >>>>> De: Benny Malengier >>> <ben...@gm...> >>> >> > >>>>> Objet: preparing for >>> 3.1.3 >>> >> > >>>>> À: "Gramps Development >>> List" >>> >> <gra...@li...>, >>> >> > >>> "Jérôme" <rom...@ya...>, >>> >> > >>> "Stéphane Charette" <ste...@gm...> >>> >> > >>>>> Date: Dimanche 22 >>> Novembre 2009, >>> >> > 10h11 >>> >> > >>>>> All, the roadmap is >>> now on >>> >> > >>>>> 100%, so we can prepare >>> for >>> >> 3.1.3. >>> >> > Could >>> >> > >>>>> everyone test perhaps a >>> GEDCOM >>> >> and an >>> >> > XML export >>> >> > >>> of their >>> >> > >>>>> data >>> >> > >>>>> (filtered somehow), and >>> then >>> >> import >>> >> > again in an >>> >> > >>> empty tree. >>> >> > >>>>> The last >>> >> > >>>>> things changes are >>> related to >>> >> that, >>> >> > and GEDCOM >>> >> > >>> changes are >>> >> > >>>>> sensitive. >>> >> > >>>>> >>> >> > >>>>> Jerome, can you check >>> the po file >>> >> is >>> >> > up to date, >>> >> > >>> perhaps >>> >> > >>>>> send mail to >>> >> > >>>>> translators with % >>> completion of >>> >> their >>> >> > language >>> >> > >>> as >>> >> > >>>>> information? >>> >> > >>>>> >>> >> > >>>>> Stephane, do you have >>> time >>> >> somewhere >>> >> > in the coming >>> >> > >>> weeks to >>> >> > >>>>> push out >>> >> > >>>>> 3.1.3? I would like to >>> see in >>> >> the >>> >> > release notes >>> >> > >>> something >>> >> > >>>>> in the line >>> >> > >>>>> of 'While the Gramps >>> developers >>> >> are >>> >> > working on a >>> >> > >>> super 3.2 >>> >> > >>>>> release in >>> >> > >>>>> a couple of months, they >>> still >>> >> had >>> >> > time for a >>> >> > >>> minor bug fix >>> >> > >>>>> release. >>> >> > >>>>> >>> >> > >>>>> The roadmap http://www.gramps-project.org/bugs/roadmap_page.php?version_id=15 >>> >> > >>>>> contains main content of >>> this >>> >> release. >>> >> > I think the >>> >> > >>> most >>> >> > >>>>> striking: >>> >> > >>>>> >>> >> > >>>>> * the annoying tooltip >>> messages >>> >> in >>> >> > latest distro's >>> >> > >>> are no >>> >> > >>>>> longer present >>> >> > >>>>> * some GEDCOM fixes >>> (timestamp >>> >> on >>> >> > persons now >>> >> > >>> kept, MEDI >>> >> > >>>>> import, ...) >>> >> > >>>>> * some data that was not >>> present >>> >> in >>> >> > filtered data >>> >> > >>> is now >>> >> > >>>>> present >>> >> > >>>>> (source page, ...) >>> >> > >>>>> * windows / or \ paths >>> in >>> >> webreport >>> >> > cleaned up >>> >> > >>>>> * ... >>> >> > >>>>> >>> >> > >>>>> Benny >>> >> > >>>>> >>> >> > >>>> >>> >> > >>>> >>> >> > >>>> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> > > >>> >> > >>> >> > >>> >> > >>> >> >>> ------------------------------------------------------------------------------ >>> >> > Join us December 9, 2009 for the Red Hat >>> Virtual >>> >> > Experience, >>> >> > a free event focused on virtualization and >>> cloud >>> >> computing. >>> >> > >>> >> > Attend in-depth sessions from your desk. Your >>> couch. >>> >> > Anywhere. >>> >> > http://p.sf.net/sfu/redhat-sfdev2dev>>> >> > >>> _______________________________________________ >>> >> > Gramps-devel mailing list >>> >> > Gra...@li... >>> >> > https://lists.sourceforge.net/lists/listinfo/gramps-devel >>> >> > >>> >> >>> >> >>> >> >>> >> >>> >> >>> ------------------------------------------------------------------------------ >>> >> Join us December 9, 2009 for the Red Hat Virtual >>> >> Experience, >>> >> a free event focused on virtualization and cloud >>> computing. >>> >> >>> >> Attend in-depth sessions from your desk. Your >>> couch. >>> >> Anywhere. >>> >> http://p.sf.net/sfu/redhat-sfdev2dev>>> >> _______________________________________________ >>> >> Gramps-devel mailing list >>> >> Gramps- de...@li... >>> >> https://lists.sourceforge.net/lists/listinfo/gramps-devel>>> >> >>> > >>> > >>> > >>> > >>> >> >> >> >> > |