From: Gerald B. <ger...@gm...> - 2009-03-26 19:56:14
|
I don't want to cling to indentation control. I was merely trying to provide the option. I agree that most folks wouldn't use it anyway. On Thu, Mar 26, 2009 at 2:56 PM, Benny Malengier <ben...@gm...> wrote: > > > 2009/3/26 Gerald Britton <ger...@gm...> >> >> Hmmm... I think that approach will result in less fine-grained control >> over indentation. (Perhaps you want some tr's indented and others >> not). Whether it makes any practical difference is another question. > > As Kees says, there is no need at all for control over intendation. I fail > to see why you want to cling to it. > >> >> Probably we need to work it up a couple of ways then see which one we >> find most pleasing in the end. Also, let's keep in mind that the >> purely web-oriented reports like WebCal and Nar-Web will likely use >> the Html class directly so we should keep the option but consider >> changing the default to True. > > Nar web already has a basepage, this need will remain. A way to convert > styled tags to html tags will also be needed. This higher level logic should > not be inside the Html class. It can be done using the Html class however, > but then inside something like HtmlPage, as this only needs to be > implemented once, not in every html output. > > Benny > >> >> On Thu, Mar 26, 2009 at 12:01 PM, Benny Malengier >> <ben...@gm...> wrote: >> > >> > >> > 2009/3/26 Gerald Britton <ger...@gm...> >> >> >> >> I believe the argument is valid, because one goal for the write() >> >> method to stay out of the way as much as possible -- that is not to >> >> inspect the data for special processing but just to regurgitate it >> >> faithfully. Also, if your file looks like this: >> >> >> >> <html><head><title>Title</title></head><body>Body</body></html> >> >> >> >> If you do View Source in Firefox, e.g. you see just that (and you >> >> should). Putting explict indents in makes it more readable with this >> >> parameter. >> >> >> >> Of course the indent parameter is optional, and if you use a different >> >> tool to view the source then it can be left out entirely and the whole >> >> discussion is moot. >> >> >> >> I take your point about making indent=True the default, however. I >> >> believe that it is probably the more common case. It shouldn't cause >> >> much problem to retrofit in WebCal either, since it is used in most >> >> calls. (We only have to find where it is *not* used and add >> >> indent=False. Should be trivial.) >> > >> > Personally I would remove the indent also. >> > If we go to a htmlfile backend, then one will have a write function >> > there >> > and a close function. This write function can be passed indent True or >> > False, and details: indentoverride = {'tr' : False}, and do all that is >> > needed. >> > >> > So, >> > >> > htmlpage = HtmlPage('filename', indent=True, indentoverride={'tr': >> > False}) >> > #do Html class stuff >> > html = Html(....) >> > .... >> > htmlpage.write(html) >> > htmlpage.close() >> > >> > The above close would write out the file with the required indendation >> > using >> > the internal html object. >> > It seems appropriate to manage indentation there. >> > >> > Benny >> > >> >> >> >> -- >> Gerald Britton > > -- Gerald Britton |