From: Jérôme <rom...@ya...> - 2009-02-13 13:24:12
|
> Should we add those entire strings to be translated? Or just the _("before"), _("after"), etc.? True, using translated words instead of "before" "between d1 and d2" will return less errors. I cannot test with non-ASCII characters (PEP) :"from to" or "after", but should be the same result. :) For tests on (French calendar), maybe by trying : ("Jul 3, 1982", "3 Germinal 1982 (French Republican)", True), ("Aug 3, 1800", "15 Thermidor 8 (French Republican)", True), ("after Aug 3, 1800", "before 15 Thermidor 8 (French Republican)", False), Commas, separator (-), calendar names and maybe place of the month|day might introduce other parsing/displaying differences ! Should be OK with date tuples. Jérôme Jérôme a écrit : >> All logic of french republican should move to the english base >> class, then all derived classes will return the same result, and >> only the words used are different. I believe this problem is a >> consequence of Jerome starting to change french republican logic >> only in the french date handler. > > Change on trunk is now on english/core base ! > (gen/lib/calendar.py or DateParser.py) > Note, the comment on _Date_fr is not related to last change (French > calendar) : > > "# This self._numeric is different from the base > # avoid bug gregorian / french calendar conversion (+/-10 days)" > > I had just added a custom _display_french on 3.0.x (removed on trunk), > this is an other bug (2/3 years ago !!!) > > => a custom def _display_gregorian(self, date_val) on _Date_fr.py > because there was this "old" conversion error on dates and fr_CH used > german date format (with a dot and a space after day)... > > PS: Others locales do not need a custom "display_gregorian" if the code > is the same as _DateDisplay.py. :) > >> The test suite should load all locale specific tests one by one and >> run the test. Gramps loads a datehandler according to the locale, >> there is no need for the testsuite to do that, it should test them >> all. There is more chance of an error being introduced in eg date_nl >> than in the base class. >> Is this possible? > > It was possible before !!! > Previous script was able to test differents locales (fr_CH, fr_BE, > fr_CA, fr_FR) by setting differents LANG(UAGE). Maybe could be useful > for en_GB or en_AU ? > http://gramps.svn.sourceforge.net/viewvc/gramps/branches/gramps22/test/dates.sh > http://gramps.svn.sourceforge.net/viewvc/gramps/branches/gramps22/src/date_test.py > > > Also, I tried DateParserDisplayTest tool or filter match and did not see > mistakes between date displayer and date parser or with filter matching > a wrong date (before, after, span), under my locale ! > http://www.gramps-project.org/bugs/view.php?id=2291 > > Previously, test on date had difficulties on calendars with more than 12 > months (HEBREW, FRENCH). > > Finaly, is it possible to add an other conversion test ? > > * a date with iso format date (year, month, day) > * a calendar > * to get the sdn by using def calendar_sdn(year, month, day) : the template. > > * test with others calendars > * to use the sdn on def calendar_ymd(sdn), we get a iso format date > (year, month, day) > * to get the sdn by using testing calendar def calendar_sdn(year, month, > day) > * to compare template sdn with sdn produced by testing calendar > > http://www.nabble.com/Re%3A-Swedish-calendar-p21582252.html > > > > Jérôme > > > Doug Blank a écrit : >> On Wed, Feb 11, 2009 at 8:09 AM, Benny Malengier >> <ben...@gm... <mailto:ben...@gm...>> wrote: >> >> >> >> 2009/2/11 Doug Blank <dou...@gm... >> <mailto:dou...@gm...>> >> >> On Wed, Feb 11, 2009 at 7:17 AM, Peter Landgren >> <pet...@te... <mailto:pet...@te...>> wrote: >> >> I did some further test. >> >> If I change all English keywords, like "before", "after" >> ...to Swedish, I get only errors for the two test cases with >> "French Republican". >> >> So you need to run it not just with correct locale; the >> complete system must be in that locale, not only gramps. It >> does not help to set LANG and LANGUAE. >> >> /Peter >> >> >> How do we want to handle this going forward? Should we add those >> entire strings to be translated? Or just the _("before"), >> _("after"), etc.? >> >> >> Nothing should be translated. >> The datehandlers are locale specific, and no translation should happen. >> >> All logic of french republican should move to the english base >> class, then all derived classes will return the same result, and >> only the words used are different. I believe this problem is a >> consequence of Jerome starting to change french republican logic >> only in the french date handler. >> >> If people want in their language the dates with same logic as >> English date handler/parser, they should just make a dummy class >> deriving from it and change the text strings. >> >> The test suite should load all locale specific tests one by one and >> run the test. Gramps loads a datehandler according to the locale, >> there is no need for the testsuite to do that, it should test them >> all. There is more chance of an error being introduced in eg date_nl >> than in the base class. >> >> Is this possible? >> >> >> So, you are suggesting that the test code go through all of the locales, >> and test the date parser with strings from the associated language? Is >> there an automatic way to find out what locales are installed? Do we >> have a complete list of locales that GRAMPS supports? If so, then we >> should make a test suite for each one, and test it if it is installed. >> >> -Doug >> >> >> >> >> Benny >> >> Benny >> >> >> >> >> >> > Is it possible to pass all tests with success ? >> >> >> Great! >> >> -Doug >> >> >> Yes, See above. >> >> > Under my locale: >> >> > > AssertionError: 'before 1960' and 'before 1961' did not >> match >> >> > > AssertionError: 'before 1960' and 'dec 31, 1959' did >> not match >> >> > > AssertionError: 'from 1950 to 1955' and '1951' did not >> match >> >> > >> >> > .... >> >> > >> >> > > AssertionError: '1707-01-01 (Svensk)' and '1706-12-31 >> (Juliansk)' did >> >> > >> >> > not match >> >> > >> >> > (not_match.gz) >> >> > >> >> > > I have commited a version with invalid dates removed. >> However, I can >> >> > > only get correct result with the Swedish words for >> Julian/Swedish >> >> > > (Juliansk/Svensk). >> >> > > >> >> > > /Peter >> >> > > >> >> > > >> >> > > >> ------------------------------------------------------------------------ >> >> > > >> >> > > >> ------------------------------------------------------------------------- >> >> > >----- Create and Deploy Rich Internet Apps outside the >> browser with >> >> > > Adobe(R)AIR(TM) software. With Adobe AIR, Ajax >> developers can use >> >> > > existing skills and code to build responsive, highly >> engaging >> >> > > applications that combine the power of local resources >> and data with the >> >> > > reach of the web. Download the Adobe AIR SDK and Ajax >> docs to start >> >> > > building applications today-http://p.sf.net/sfu/adobe-com >> >> > > >> >> > > >> >> > > >> ------------------------------------------------------------------------ >> >> > > >> >> > > _______________________________________________ >> >> > > Gramps-devel mailing list >> >> > > Gra...@li... >> <mailto:Gra...@li...> >> >> > > https://lists.sourceforge.net/lists/listinfo/gramps-devel >> >> -- >> >> Peter Landgren >> >> Talken Hagen >> >> 671 94 BRUNSKOG >> >> 0570-530 21 >> >> 070-635 4719 >> >> pet...@te... <mailto:pet...@te...> >> >> Skype: pgl4820.2 >> >> >> >> ------------------------------------------------------------------------------ >> >> Create and Deploy Rich Internet Apps outside the browser with >> Adobe(R)AIR(TM) >> software. With Adobe AIR, Ajax developers can use existing >> skills and code to >> build responsive, highly engaging applications that combine the >> power of local >> resources and data with the reach of the web. Download the Adobe >> AIR SDK and >> Ajax docs to start building applications >> today-http://p.sf.net/sfu/adobe-com >> _______________________________________________ >> Gramps-devel mailing list >> Gra...@li... >> <mailto:Gra...@li...> >> https://lists.sourceforge.net/lists/listinfo/gramps-devel >> >> >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------------ >> Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) >> software. With Adobe AIR, Ajax developers can use existing skills and code to >> build responsive, highly engaging applications that combine the power of local >> resources and data with the reach of the web. Download the Adobe AIR SDK and >> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Gramps-devel mailing list >> Gra...@li... >> https://lists.sourceforge.net/lists/listinfo/gramps-devel > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel |