Re: [Gramps-devel] "is None" vs "== None"

[Gerald B. <ger...@gm...>]

thanks Rob, although I think I can do it in one or two commands using sed:

e.g, sed -i 's/== None/is None/g'

FWIW I also see that there are some occurrences of == True and ==
False that should be changed as well.  e.g.

    if a == True:

should just be

    if a:

according to PEP 8

On Fri, Jan 23, 2009 at 4:02 PM, Rob Healey <rob...@gm...> wrote:
> Dear Gerald:
>
> I am more than willing and happy to help you if you would like the help???
>
> Just give me a list of files that need to be fixed, and which ones that you
> would like me to fix???
>
> Sincerely Yours,
> Rob
>
>
> On Fri, Jan 23, 2009 at 12:17 PM, Gerald Britton <ger...@gm...>
> wrote:
>>
>> Hi all,
>>
>> A while back I went through the source tree and replaced expressions
>> like "if a == None" with "if a is None."  The reason is that the
>> latter is significantly faster (about 30%).  There is actually an
>> official recommendation on this that we should be following:
>>
>> http://www.python.org/dev/peps/pep-0008/
>>
>> "    - Comparisons to singletons like None should always be done with
>>      'is' or 'is not', never the equality operators.
>> "
>>
>> Today I svn'd up and out of curiosity grep'd the tree to look for
>> "bad" expressions.  I found over 400 occurences of "== None" and more
>> than a 100 "!= None."
>>
>> I'm willing to work up a (probably big) patch to try to correct this,
>> but I thought that I should bring it to the general attention of the
>> list so that we can try to stay closer to PEP 8 going forward.
>>
>> Cheers to all and a great weekend!
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by:
>> SourcForge Community
>> SourceForge wants to tell your story.
>> http://p.sf.net/sfu/sf-spreadtheword
>> _______________________________________________
>> Gramps-devel mailing list
>> Gra...@li...
>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>