Re: [Gramps-devel] Relationship graph - order of children

[Benny M. <ben...@gm...>]

Olivier, open a bug ticket with the patch and post the link here in this
thread.
Somebody can review it then.
>From just reading the mail, I do wonder why you chose src/gen/db/base.py to
add this method. Does it not fit more with ReportUtils or so?

Benny

2009/1/21 Jérôme <rom...@ya...>

> Olivier,
>
> > and saw that actually there was no ordering of the children.
>
> +1
>
> > I decided to implement it, and it looks like it works. How should I
> propose/submit it?
>
> Maybe this could be added on http://bugs.gramps-project.org/ as [feature
> request] !
>
>
> Jérôme
>
> Peter Landgren a écrit :
> >
> >
> > Olivier,
> >
> > This feature is something my wife always wanted for the relationship
> graphs.
> >
> > I managed by manual editing the dot file, but this could only be done
> > for a small one.
> >
> > /Peter
> >
> >  > Hi,
> >
> >  >
> >
> >  > I used some time ago the "relationship graph" to create a family
> > tree, but
> >
> >  > the order among the children was wrong, so I decided to look at it a
> bit,
> >
> >  > and saw that actually there was no ordering of the children.
> >
> >  >
> >
> >  > So I read a bit about graphviz and dot files, and saw that it could be
> >
> >  > solved using "instructions" like
> >
> >  >
> >
> >  > { rank=same; I0001 -> I0004 [ style = invis ]; }
> >
> >  >
> >
> >  > I decided to implement it, and it looks like it works. How should I
> >
> >  > propose/submit it?
> >
> >  >
> >
> >  > The changes I made are:
> >
> >  >
> >
> >  > * src/ReportBase/_GraphvizReportDialog.py:
> >
> >  > I added a method "add_invis_links" that takes a list of persons id and
> >
> >  > create a line like the one above
> >
> >  > * src/gen/db/base.py:
> >
> >  > I added method "get_person_handles_by_families" that creates a list of
> >
> >  > handles of all the people as
> >
> >  > children of families and ordered as such. People that are not children
> >
> >  > are listed at the end for completion.
> >
> >  > * src/plugins/graph/GVRelGraph.py
> >
> >  > I use the methods above to order the families.
> >
> >  >
> >
> >  > I've also attach a patch I made with eclipse/svn plugin if that helps.
> >
> >  >
> >
> >  > Regards,
> >
> >  >
> >
> >  > Olivier
> >
> > --
> >
> > Peter Landgren
> >
> > Talken Hagen
> >
> > 671 94 BRUNSKOG
> >
> > 0570-530 21
> >
> > 070-635 4719
> >
> > pet...@te...
> >
> > Skype: pgl4820.2
> >
> >
> > ------------------------------------------------------------------------
> >
> >
> ------------------------------------------------------------------------------
> > This SF.net email is sponsored by:
> > SourcForge Community
> > SourceForge wants to tell your story.
> > http://p.sf.net/sfu/sf-spreadtheword
> >
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Gramps-devel mailing list
> > Gra...@li...
> > https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>