Menu
▾
▴
Re: [Gramps-bugs] <pre> tag crippled in 3.0 (web report)?
|
From: Benny M. <ben...@gm...> - 2008-04-07 14:59:43
|
2008/4/7, David Martin <mar...@gm...>: > > A good example of my problem is shown in the differences between these two > pages generated by v2.2.10 and v3.0.0 respectively: > http://home.comcast.net/~davidmartin/ppl/a/b/abc80ae049c278e6c5d.html<http://home.comcast.net/%7Edavidmartin/ppl/a/b/abc80ae049c278e6c5d.html> > http://home.comcast.net/~davidmartin/tmp/ppl/a/b/abc80ae049c278e6c5d.html<http://home.comcast.net/%7Edavidmartin/tmp/ppl/a/b/abc80ae049c278e6c5d.html> > > Both are generated from the same note, where I enclosed the text of the > will in <pre></pre> tags to maintain the spacing of the text. I have done > basically the same thing in hundreds of notes scattered throughout my > database... > > You will notice that v2 translated the line breaks within <pre> tags as > <br>, and v3 translated the same line breaks as hard <p></p> (not a CSS > thing), resulting in very large, ugly spacing that looks nothing like > intended... > Not the above. In 3.0.0, a newline in the note is translated to <p></p>, not as <br> This is line 629 in the NarrativeWeb.py file: text = u"</p>\n\t\t<p>".join(text.split("\n")) David, Brian, perhaps it is nicer to have only double enters in note translate to a paragraph, so something like text = u"</p>\n\t\t<p>".join(text.split("\n\n")) text = u"<br>\n\t\t".join(text.split("\n")) instead? However, we would need to match with a regex first to change spaces, so "\n \n" is replaced by "\n\n" first. David, can you try that? It will probably solve things for you. The above line in version 2.2.10 used to be: text = u"<br>".join(text.split("\n")) so using that on your pc will certainly make things back as before. Jason, as the person who made the css, is there another way to influence linebreaks, paragraphs? What would your take be on translating a note with newlines to html code? Use <br>? Is it really needed to translate linebreaks as <p>, would two new lines not automatically give nice flowing text? Could we use a custom tag, like <notenewline> which the css then handles?? Benny Brian, Benny (et al), thanks for leaving this open and for looking into it! > > David > > > On 4/7/08, Benny Malengier <ben...@gm...> wrote: > > > > > > > > 2008/4/7, David Martin <mar...@gm...>: > > > > > > Ouch! So because you don't condone it, those of us who have naively > > > used HTML in notes should be punished? I don't mean to be flippant, but > > > that's the way I read your reply... please let me know if I misinterpreted > > > you. > > > > > > > I'll let Brian answer about what he means. > > > > > > I would love to hear your advice on how to better structure a narrative > > > web report without using HTML tags in notes, but as I said before, it will > > > take weeks to "undo" them all... and I only used the <pre> tag because that > > > is precisely what GRAMPS 2 used when I did as you suggested and checked the > > > "preformatted" checkbox. The trouble with that checkbox is that it isn't > > > selective... it affects either the entire note or none of it at all. > > > > > > > Yes, but in 3.0.0 you have multiple notes, so you could split this up. > > Mixing preformatted and not preformatted by using tags yourself in the notes > > was apparently possible in 2.2.x, but not something that was not actually > > supported or meant to happen by the developers. So the <pre> was not > > intentionally broken in 3.0.0, it just didn't occur to us it should be > > possible at all. > > > > Let's take a step back, and go to the use case you have. What do you > > want to achieve, and how can it be made possible in GRAMPS without > > unintended use of certain code. If gramps writes out the note in a web > > report as it should, what is preventing the webbrowser to interpret the > > <pre> correctly? Is it something in the css? > > > > > > > > So should I take away from this that GRAMPS 3 interpreting linebreaks > > > inside <pre> tags as paragraphs rather than <br> is permanent behavior? > > > ...not open to discussion? > > > > > > > As I say above, why is this happening. Personally I program python, html > > is not my thing, so why are it paragraphs now? Is it not just a css thing > > you could change? Can you point us to an example website? > > > > > > Benny > > > > Thanks, > > > David > > > > > > > > > On 4/5/08, Brian Matherly <br...@gr...> wrote: > > > > > > > > David, > > > > > > > > > I thought I remembered seeing this discussed while > > > > > you were developing 3.0, > > > > > so I hesitated to post it to the bugs forum... but I > > > > > can't find the posts (I > > > > > think) I remember now. > > > > > > > > > > Was the <pre> tag intentionally crippled in 3.0? I > > > > > thought there was > > > > > mention of something like that while you were > > > > > working on formatted notes... > > > > > but since that was removed, shouldn't <pre> still > > > > > work as it did before? > > > > > > > > > > I have been using piecemeal HTML tags in my notes > > > > > since day one, so I have > > > > > quite a huge number of them now. It would take > > > > > weeks to go back now and > > > > > remove all of the line breaks that I *intentionally* > > > > > put in my > > > > > <pre>-formatted notes because 2.x supported > > > > > them--something I may be faced > > > > > with again when you do add note formatting, and > > > > > certainly don't want to do > > > > > twice! > > > > > > > > > > The problem is that line breaks within the <pre> > > > > > section were translated as > > > > > <br> before, but now are <p></p>. I only used <pre> > > > > > because it was very > > > > > simple and effective at the time... > > > > > > > > Sorry, but I don't know the answer to your question. I > > > > know a lot of people think putting HTML tags in notes > > > > is clever. But personally, I do not condone the use of > > > > HTML in notes under any circumstance. > > > > > > > > If you want to use line breaks in your notes, I > > > > recommend that you check the "preformatted" checkbox, > > > > and then format the notes in the manor you see fit. > > > > > > > > Regards, > > > > > > > > ~Brian > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > > > Register now and save $200. Hurry, offer ends at 11:59 p.m., > > > Monday, April 7! Use priority code J8TLD2. > > > > > > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > > > _______________________________________________ > > > Gramps-bugs mailing list > > > Gra...@li... > > > https://lists.sourceforge.net/lists/listinfo/gramps-bugs > > > > > > > > > |