From: <ben...@ug...> - 2006-11-30 22:01:54
|
Alex, In attachment the diff to PlaceView, so that google maps is called correctl= y, indepentenly from how the user inputted latitude and longitude in GRAMPS. And the PlaceUtils.py module, containing the conversion function, needed fo= r this. As the expert, you should go over the internationalisation in PlaceUtils.py for latitude and longitude. It's in the beginning of the file. I'm not so sure = if the way I programmed that is good. The trick is to translate 2=C2=B053'9.23= "E, which a dutch user might enter as 2=C2=B053'9.23"O, as 'east' is 'oost' in = dutch. This localisation is also the only thing not tested. :-( I suppose to test that I should change a po file. Lastly, the end of the file contains tests, whith: if __name__ =3D=3D '__main__': run_tests I suppose you should delete that paragraph, as I did not see this construct= in other modules of GRAMPS. If you have remarks, changes that are needed, let me know, and I'll do them= . Benny Quoting Alex Roitman <sh...@gr...>: > Benny, > > On Thu, 2006-10-05 at 20:40 +0200, ben...@ug... wrote: >> Right now in 2.1.95 lat and lon can be entered, but there is no >> check on their >> form. >> I would suggest to check on the format like what can be retrieved in >> eg google >> earth: eg Lat 50=C2=B050'59.66"N Lon: 2=C2=B053'9.23"E >> >> Here Lat degrees=C2=B0 go from 0 to 89, seconds' from 0 to 59 and " from= 0.00 to >> 59.99, follewed by N or S, and >> Lon degrees=C2=B0 go from 0 to 179, seconds' from 0 to 59 and " from >> 0.00 to 59.99 >> followed by E or W > > After discussing this for a while, I distinctly remember you > sending code with PlaceUtils or somesuch -- a tool to convert > between the until and/or check validity. I can't seem to find it. > > Do you still have it? We decided to do it post-2.2, > so now is as good a time as it will ever be :-) > > Alex > > -- > Alexander Roitman http://www.gramps-project.org > ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. |