Re: [Gramps-devel] GraphViz plugin changes/improvements

[Eero T. <ee...@us...>]

On Thursday 26 January 2006 20:29, Alex Roitman wrote:
> > Attached is a patch to the Gramps GraphViz plugin that contains
> > following changes:
> >
> > Bugfixes:
> > - Quote node and edge identifiers
> >   -> fixes problem with Gramps IDs having non-alphanumeric characters
> > - Make latin-1 conversion option explicit to user, not depending on
> > font -> Fix for the text encoding problem with fonts & output formats
> >
> > Feature requests:
> > - Women have rounded boxes, except in filled mode
> >   (current GraphViz doesn't support boxes that are both rounded and
> > filled)
> >
> > Re-factoring:
> > - Split large functions to smaller ones to make code more readable
> > - Renamed few methods and variables to what they actually do
> > - Collect the report text to a buffer first so that it can be converted
> > to latin-1 at one go. This could allow later on to modify the buffer in
> > place without regenerating the report (the output is normally some tens
> > of KBs so I don't think it's a problem, but it's easy to revert)
> > - Move common style stuff to GraphViz header and remove from .dot
> >   comments stuff that's obvious from first .dot file settings
> >   -> Smaller GraphViz file (helps with above)
> >
> > Please test.
>
> Maybe a better idea would be to email the whole file,
> so that people can place it into ~/.gramps/plugins and test
> without having the source built/installed.

Ok, the whole file is attached.


> I'll let you do that, in case there are further modifications
> you want to share.

Well, first I'd like to know whether Doug's widget stuff will get
adopted? :-)


	- Eero