Re: Mouse in x11 interactive terminal

[Ethan M. <merritt@u.washington.edu>]

On Friday 29 July 2005 04:54 am, Petr Mikulik wrote:
> >> It looks that with this this removal from plot.c
> >> 
> >> #ifdef PIPE_IPC
> >>     /* isatty_state is set here and nowhere else! (used in term/x11.trm) */
> >>     isatty_state = interactive;
> >>     if (!isatty_state) {
> >>        /* stdin is not from a tty --> Turn mouse off.
> >>         * can be turned on again, e.g. if the user
> >>         * wants to write on a pipe to gnuplot */
> >>        mouse_setting.on = 0;
> >>     }
> >> #endif
> >> 
> >> I can also remove all other occurencies of the variable "isatty_state" 

That looks correct to me.




[it doesn't matter now, but...]

The original logic of having a global variable "isatty_state" escapes me.
There was already a global "interactive", and the only initialization of
isatty_state is the one shown above.  I fail to see how having two
globals is an improvement over just using the one that was there already.

If we get rid of isatty_state in x11.trm, then the only two remaining
drivers that refer to the global "interactive" flag are

post.trm:
                    if ((lf && lf->interactive) || interactive)
                        PS_load_fontfile(new_ps_fontfile,FALSE);

amiga.trm:
		    doesn't do anything in term->text or term->suspend
		    if (!interactive)


The postscript use looks dubious to me.  Why would we not want to 
load a font file in non-interactive mode?
(Harald, do you remember this?)

The amiga code we can do away with by dropping amiga support :-)





-- 
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195