Re: mouse.c (event_reset) bug

[<tim...@en...>]

Ethan Merritt wrote:

>On Friday 15 July 2005 04:15 pm, Timoth=C3=A9e Lecomte wrote:
> =20
>
>>>I am not certain this fix is corrent, since
>>>term->set_cursor() is also called from builtin_cancel_zoom()
>>>
>>>     =20
>>>
>>No, builtin_cancel_zoom returns before calling term->set_cursor()=20
>>because of the following test :
>>
>>    *if* (!setting_zoom_region)
>>	*return* (char *) 0;
>>   =20
>>
>
>For x11 one could imagine that the plot window was closed in the middle
>of doing a zoom. In this case the test you quote above would not stop
>X11_set_cursor from being called, and since closing the plot window may
>have shut down the communication channel we still must test it
>explicitly inside X11_set_cursor.  I do not know if a similar sequence
>of events is possible with your new driver.
> =20
>
I have chosen to just hide the terminal window when the user closes it=20
via the menu or the window manager. Thus, it is still available to=20
answer to such calls.

> =20
>
>>Of course, I can make such a test. And I will. I thought it would be=20
>>easier to fix the calling path ;-)
>>   =20
>>
>
>I understood that.  I am just pointing out that if you truly want
>to protect the calling path, a different fix may be needed.
> =20
>
Ok, I understand. No problem !

Timoth=C3=A9e