|
From: <wie...@we...> - 2005-07-04 21:14:13
|
Ethan A Merritt wrote: > The internal evaluation code uses switch(value.type) statements everywhere. > At the very least, if you add a new type without adding new case > statements you will cause compiler warnings. Easy enough to do, but my > feeling is that if you want to go to this trouble then we might just as > well remove the conditional compilation flags around the string variable > code and leave it at that. I think I got the point. Thanks for your patience. I've already said that I regret ever having suggested this. :-) Removing GP_STRING_VARS would be nice, but isn't really neccessary. Tomorrow I'll upload a clean up for the last patch. BTW: During my tests, I've stumbled over a small memory leak, which took me quite long to locate. Eventually, it has been in there before my changes. The function f_call() pops a "struct value" from the stack. If this contains a string, it ought to be freed. Patch attached. Juergen |