|
From: Ethan M. <merritt@u.washington.edu> - 2005-06-28 20:03:20
|
On Tuesday 28 June 2005 12:54 pm, Hans-Bernhard Br=F6ker wrote: > IMHO, isstring() should have been renamed=20 > to isstringconst(), and a new isstring() been implemented that computes=20 > the above || expression. I will consolidate the (isstring() || isstringvar()) test into a single call isstringvalue(). This simplifies the code, which is good. If/when Juergen comes up with a fully working isstringfunc(), that can be added at a single point in isstringvalue(). =20 By my current count there are 14 of these consolidated tests,=20 as compareded to ~60 remaining instances of the original isstring(). So I agree with you in principle, but let's get the simplified code checked out first before considering a grand re-naming. =2D-=20 Ethan A Merritt merritt@u.washington.edu Biomolecular Structure Center Mailstop 357742 University of Washington, Seattle, WA 98195 |