Re: linetype palette

[Aapo L. <aap...@gm...>]

On Thu, 2005-06-16 at 11:32 +0200, Johannes Zellner wrote:
> The problem was a small bug in my depth patch, see the patches section
> at sourceforge for the actual patch.

Checked your patch.  I'd say it is a cool addition that makes the
scansforward, scansbackward and scansautomatic options unnecessary.  I
think the functionality it provides is very important; especially
because it seems to be impossible to draw e.g. the two toruses properly
with the current CVS version.  And I think the patch is also reasonably
fast, I didn't have any problems with the interactive mouse mode either.
Thanks for the patch; I added it to my own Gnuplot.  :-)

Few thing I noticed; even though your coding is quite "clean", I'd
personally like some more comments in your code.  Especially the various
"pm3d_depth_queue" functions would require some commentation for easier
understanding.  Furthermore, I didn't understand following oddity, at
least for portability I suppose things like

quadrangles = (quadrangle*)0;  should be  quadrangles = NULL;

or am I missing something?


> Btw.: how should I proceed to get the depth patch into gnuplot?

Unfortunately I don't know.  I suppose you must bug one of the devs to
add the patch into the CVS; the "patch" section in Sourceforge seems not
to work very well.

Best Regards,
Aapo Lankinen


PS. I know it's not your fault, but the newest version of your patch
didn't go cleanly against the current CVS.  There was a problem with
indentation changes or something like that in the CVS...

-- 
Aapo Lankinen <aap...@gm...>