|
From: Daniel J S. <dan...@ie...> - 2005-06-08 05:40:57
|
Dimitrios Apostolou wrote: > Daniel J Sebald wrote: > >> Please *explain* why the patch is faster. Those listening will >> understand. Also, when running diff be sure to use unified (-u) so >> that it indicates what file the hunks come from. > > > I don't know why it is faster. I just wrote a simple parser. I don't > understand what more the old parser does. I just can see that it is much > more complicated. My guess is that after so many years of development > and after many additions that today we see but can't figure out, the > code became a bit "bloated". (OK, saw this file in a backlog of email. Hans must be sending these through manually.) It is a possibility. That matrix code is sort of a tacked on thing. But unless we understand what the problem is how can we know that there is extraneous, inefficient code? However, if you believe what you've coded meets the definitions and format in the documentation and is faster, then consider redoing the patch with the old, unneeded code removed. Otherwise, it will leave cruft floating about, just what you are attempting to improve upon. Thanks, Dan |