|
From: Dimitrios A. <ji...@gm...> - 2005-06-03 21:21:03
|
> On Thursday 02 June 2005 03:53 pm, Dimitrios Apostolou wrote: >=20 >>So I submit to you a patch (against the v. 4.0 gnuplot) for the file=20 >>src/datafile.c as a proof of concept >=20 >=20 > Could you please re-do the patch using > diff -ur <oldfile> <newfile> >=20 I submit the patch for a third time, sorry for the spamming, but since=20 I=C2=B4m not subscribed to the list my emails wait for approval. This time I used the format you suggested: diff -ur <oldfile> <newfile> >>There are many things in my code that you 'll not probably like. >=20 >=20 > Your comments worry me. For instance: >=20 > < /* malloc the maximum we may use, it's ok in an overcommiting OS lik= e linux */ > < tmp_arr =3D gp_alloc(filesize * sizeof(float), "df_matrix"); >=20 > gnuplot core code must run on systems other than linux. > And even for linux your statement is not true. Many people doing > serious number crunching will not run linux in overcommit mode, because > it is too painful to see a computation which has already run for 3 days > be killed by the OOM killer just because someone has opened a web brows= er, > or in this case because they try to run gnuplot. As I said my code only serves as a proof of concept. In case you care to=20 use it this is one of the things that should change. Dimitris |