|
From: Ethan M. <merritt@u.washington.edu> - 2005-06-02 20:04:32
|
On Wednesday 25 May 2005 05:03 am, Lars Hecking wrote:
>
> may I ask to advance the #define'd compile-time parameter
> MAX_NUM_VAR
> in src/syscfg.h from 5 to something like 20 or so? :-)
The arrays that use MAX_NUM_VAR are horribly wasteful,
particularly if we bump it up to a larger number.
e.g.: char c_dummy_var[MAX_NUM_VAR][MAX_ID_LEN+1];
would be reserving 20*50 chars of storage to hold what
is usually 2-3 instances of single-characters names like
"u", "v" or "w".
How about changing these arrays to hold dynamically
allocated pointers instead. Then we would replace existing
assignments
strcpy(set_dummy_var[0], "x");
with calls to a routine
load_dummy_var(char *var, char *name)
{
free(var);
var = gp_strdup(name);
}
--
Ethan A Merritt merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195
|