|
From: Daniel J S. <dan...@ie...> - 2005-03-02 15:47:37
|
Petr Mikulik wrote: >>>Or even (3): remove all #ifdef PM3D. Now, this functionality is an inherent >>>part of gnuplot, so it does not make sense any longer to separate its source >>>code pieces visually by #ifdef PM3D ... #endif. >>> >> >>I'm fine with that. There should still be the natural division of color >>attribute code, pm3d drawing code, etc. That may already be the case, >>and #ifdef PM3D happens to comment out more than it really should. Just >>double check that things are organized well. > > > That #ifdef PM3D is there since 1999 when I developed pm3d plotting mode as > a completely new feature with new terminal entries. Nowadays, that #ifdef > PM3D does not make too much sense because much more functionality has been > added to it (i.e., not only "splot with pm3d"), and we see that it has > become an inherit part of the gnuplot core: #ifdef PM3D is not only for > 3D, but also for 2D -- so, it makes really no sense as __3D. > > Well, there are people who use gnuplot on servers, but what would they want? > To comment the whole "3D plotting" completely? That would make more sense. Right. The more natural division is between 2D and 3D. But given what Ethan has shown in the compile stats, I doubt removing the 3D portion of the code will do much; also keeping in mind I plan to integrate 2D/3D plot layout more smoothly, I doubt people will care later on about removing 3D. Dan |