|
From: Daniel J S. <dan...@ie...> - 2005-03-01 17:51:19
|
Petr Mikulik wrote:
>>I thus object to throwing out the #ifdef's. But I offer yet another option:
>>
>>(4) add an --enable switch for the new features, and change those
>>particular #ifdef's from #if PM3D to #if WANT_THESE_ROUTINES,
>>and enable that define if either PM3D or the new toggle is enabled.
>>
>>
>
>I don't like adding new --enable unless it is really really necessary for
>some testing. Either the feature is approved, or not. (People don't care
>about --enable too much, and editing config/{config.xxx, makefile.xxx} is
>ugly.)
>
>
I agree with this. Gnuplot is a fairly small program compared to many.
I'd say if people complain about needing memory space then add
conditional compiles. Most comments I see are from users who see a
patch on S.F. and say "I can use this!"; or from people who just want
things to compile seamlessly. I've yet to see someone complain about
bloatedness... except for some of us who think gnuplot uses too much
space storing data internally, say no more. :-)
Dan
|