|
From: Daniel J S. <dan...@ie...> - 2005-03-01 16:58:08
|
Petr Mikulik wrote: >>Which is preferable? >> >>(1) Leave the new options dependent on PM3D >> >>(2) Move the data structures and utility routines out of the >> #ifdef PM3D brackets, so that the new feature are available >> even if for some reason you don't want PM3D >> >> > >Or even (3): remove all #ifdef PM3D. Now, this functionality is an inherent >part of gnuplot, so it does not make sense any longer to separate its source >code pieces visually by #ifdef PM3D ... #endif. > I'm fine with that. There should still be the natural division of color attribute code, pm3d drawing code, etc. That may already be the case, and #ifdef PM3D happens to comment out more than it really should. Just double check that things are organized well. Dan |