|
From: Daniel J S. <dan...@ie...> - 2005-02-28 22:29:31
|
Ethan Merritt wrote: >Which is preferable? > >(1) Leave the new options dependent on PM3D > >(2) Move the data structures and utility routines out of the > #ifdef PM3D brackets, so that the new feature are available > even if for some reason you don't want PM3D > >Leaving things the way they are is obviously less work, but it >kind of offends my sense of esthetics to have useful code features >unecessarily dependent on unrelated options. > > Didn't we run into something similar with the image code and pm3d? I.e., we found that some things are used by the image code that if PM3D is not enabled, the image software won't compile. So we just decided to condition image code on PM3D being defined... but I too would opt for preference 2 if someone wanted to do that. Dan |