Re: Open patches that are useful for me

[Harald H. <h.h...@tu...>]

On Sun, 9 Jan 2005, Ethan Merritt wrote:

> On Sunday 09 January 2005 07:38 am, Harald Harders wrote:
> > #616199 Ignore title string after notitle
>
> This patch no longer works since the addition of string variables.

Shit. I have tried this patch (first, only for 2d plots):

--- orig/src/plot2d.c   2004-12-05 16:12:35.000000000 +0100
+++ notitle/src/plot2d.c        2005-01-09 20:54:40.000000000 +0100
@@ -1480,6 +1480,8 @@
                    if (xtitle != NULL)
                        xtitle[0] = '\0';
                    c_token++;
+                   if (try_to_get_string())
+                       int_warn(c_token, "title string ignored");
                    set_title = TRUE;
                    continue;
                }

But this only works when a string is given that can be ignored or if
notitle is the last token:

gnuplot> plot sin(x) notitle 'sine' w l
gnuplot> plot sin(x) notitle 'sine'
gnuplot> plot sin(x) notitle

It does not work if notitle is followed by other things than a string:

gnuplot> plot sin(x) notitle w l
         undefined variable: w

This error message is produced inside execute_at() by the command call
(*ft[operator].func) (&(at_ptr->actions[instruction_index].arg));

Does anybody have an idea how I can reach that the token after notitle is
evaluated if it results to a string and ignored otherwise?



> > #713166 margins changed from int to float
>
> I have no strong objection, but I have not found a case where
> the ability to adjust margins by fractional character widths
> is really needed.  Can you provide a test case?

No problem. Say, you want to produce a postscript file without whitespace
around the plot (This is useful when including these in LaTeX, for
example). Have a look at the lower edge:

set terminal postscript eps 'Times-Roman' 22
set output 'margins-1.eps'
set bmargin 1
plot sin(x)
set output
set output 'margins-2.eps'
set bmargin 2
plot sin(x)
set output

You either crop the xtics or you have white space below them.

This is one of my major problems I have using Gnuplot. My current
workaround is to use multiplot:

...
set multiplot
set size ...
set origin ...
set lmargin 0
set bmargin 0
set tmargin 0
set rmargin 0
plot ...
unset multiplot

By variing the inner size and origin, I adjust the margins. But this is a
bad hack.



> > #835235 minitics updates
>
> No opinion.

Have a look at this example:

set logscale y
set ticscale 2
#
set xrange [1.1:2]
plot 2**x
print 'vertical range not optimal'
pause -1 "Press any key"
#
set yrange [2:5]
replot
print 'range good but ytics are gone'
pause -1 "Press any key"
#
set ytics (2, 3, 4, 5)
replot
print 'range good, major tics visible, but no minor tics'
pause -1 "Press any key"
#
set mytics
replot
print 'still no minor tics'
pause -1 "Press any key"
#
set mytics (2.25, 2.5, 2.75, 3.25, 3.5, 3.75, 4.25, 4.5)
print 'explicit minor tics work with patched gnuplot'
replot
pause -1 "Press any key"


Greetings
Harald


-- 
Harald Harders
h.h...@tu...
http://www.harald-harders.de