|
From: Harald H. <h.h...@tu...> - 2005-01-08 11:25:55
|
On Fri, 7 Jan 2005, Daniel J Sebald wrote: > Harald Harders wrote: > > >On Fri, 7 Jan 2005, Ethan Merritt wrote: > > > >Please have a look at this patch. I really think it is useful. I am using > >it since I have uploaded it to sf.net and I never had any problems. > > > These all look like nice improvements. The error message is gone. > Details, including user's name show up in the file. Why not move the > patch into CVS while on the topic? One thing I wonder is if we could > include some way to provide an alternate user name or notice. For > example, say I don't want my account user name in the file, but rather a > company name, work group name, or maybe copyright notice. Does this > seem like something worthwhile? Maybe something like another > environment variable GNUPLOT_USERNAME. Or were we trying to move away > from too many environment variables for gnuplot? With unix, this patch already uses the environment variables USER or USERNAME. You can force a username by setting one of these, e.g., using a bash: USER='I myself' gnuplot I have changed it locally that also Windows looks at these environment variables. I have also thought if I would be worth to introduce something like set fileinfo username 'Harald' title 'Main plot' subject 'test' Here, also things as keywords could be set. These information could also be used by other terminals that produce output files which support information (e.g., jpeg). The fileinfo command could default to the values used at the moment. > PS: Looking through the code I see a couple things. First "gnuplot > diagram" is ok, but its technically not a diagram I guess. (But you > probably thought "gnuplot plot" just doesn't read well.) I have changed it to "gnuplot plot". If somebody has a better idea, please send it to the mailing list. > Second, the > following lines of malloc/free are generally OK. But the one case where > username2 is zero and username isn't might be a problem. (But the only > case that would happen is if the system runs out of memory right after > allocating username.) I will change it. Greetings Harald -- Harald Harders h.h...@tu... http://www.harald-harders.de |