|
From: Daniel J S. <dan...@ie...> - 2004-09-20 20:59:22
|
Petr Mikulik wrote: >>Attached is a patch to fix spelling errors in the mulitplot documentation. >> >> > >I will commit it, with yet another fix to "will a produce". > Yes, another typo. >However, I have one more major point there: >Docs says: > This grid is filled rows first or columns first depending whether > `rowmajor` or `columnmajor` is given by the subsequent option of the > multiplot command. Default is `columnmajor`. > >That's confusing: either words in the above are opposite, or "major" does >not mean "the slower scan in filling". Currently, it works this way: >"rowmajor" fills columns first, "columnmajor" fills rows first. It should be >said explicitly e.g. > Oh yeah. Something does seem to be backward. The behavior I'm seeing does look like row major, not column major. > > This grid is filled rows first or columns first depending whether > `columnmajor` or `rowmajor` is given by the subsequent option of the > multiplot command, respectively. > >Or should the keywords be renamed to e.g. "rowsfirst" and "columnsfirst"? > Although "rowsfirst" does seem less ambiguous, I think column major and row major are fairly well used terminology. So, maybe stick with that terminology and just change the documentation so that it says `rowmajor` is the default. (Octave types out a little diagram in its "help subplot" text.) >And yet another observation: >If a wrong option is given, e.g. > set multiplot layout 3,2 blacolumnmajor >produces error message: > did not expect anythig here >Firstly, there should be "anything". Secondly, the message is not >very well descriptive. What about "wrong option" instead? > Yeah, not a good comment, because obviously gnuplot does expect that something could follow. "Unrecognized option" or "Invalid option" perhaps. "wrong" sounds too much like it could be a valid keyword, but just used out of context. Dan |