Re: Problem with new binary input code

[Hans-Bernhard B. <br...@ph...>]

Ethan Merritt wrote:

> On Sunday 12 September 2004 10:15 am, Daniel J Sebald wrote:
> 
>>Hans-Bernhard Broeker wrote:
>>
>>>Better yet, Someone[^TM] take this as motivation to finally create the
>>>long overdue "properties of a plotting style" data structure.
> 
> 
> 
>>I'm not aware
>>of what the groups ideas for "properties of a plotting style" are.
> 
> 
> typedef enum int {

There's no such thing as "enum int" ;-)

> LINES, POINTSTYLE, LINESPOINTS, IMPULSES, .....
> } plot_style;

May be better to name it t_plot_style or plot_style_number or something 
like that...

> typedef struct {
> int plot_style;		/* The identifying number */

No "int" here, please.  This element is inherently of the type of
the above enum, so that's what its type should be.

> TBOOLEAN has_points; 	/* replaces the PLOT_STYLE_HAS_POINT bitflag */
> TBOOLEAN has_fill;	/* replaces the PLOT_STYLE_HAS_FILL bitflag */
> [.. more bitflags ..]
> int min_columns;
> int max_columns;
> int default_columns;
> [.. and so on ..]
> } t_plotstyle;
> 
> extern struct t_plotstyle plotstyle[] =
> { ... initialization array ... };

Exactly.  I.e., what I'm envisioning here is a modification roughly
similar to my "axis struct" project a couple of years ago.