|
From: Ethan M. <merritt@u.washington.edu> - 2004-09-12 16:24:14
|
Daniel:
I just discovered a problem with the new binary input code.
Basically it causes the to code break if any of the plot styles
defined in gp_types.h are revised.
In datafile.c there is an array
df_bin_default_columns default_style_cols[LAST_PLOT_STYLE + 1] = {
{1, 1}, /* LINES */
{1, 1}, /* POINTSTYLE */
[... and so on]
But this definition assumes that it knows the exact order and
value of the various plot styles. As I discovered when revising
and testing Volker Dobler's "sizepoints" patch, adding new plot
styles or revising the old ones causes a mismatch of the values
in this array.
I see from your comment that you already knew this might
be a problem. Well, as I just discovered, it *is* a problem.
Could you please modify this array and the code that uses it
so that rather than assuming, for instance, POINTSTYLE==1,
the array includes the actual current values to test against?
I imagine it would look something like
df_bin_default_columns default_style_cols[] = {
{LINES, 1, 1},
{POINTSTYLE, 1, 1},
[... and so on]
|