From: Hans-Bernhard B. <br...@ph...> - 2004-07-11 00:24:17
|
On Sat, 10 Jul 2004, Daniel J Sebald wrote: > > > Ethan A Merritt wrote: > > >For what it's worth - > >After I apply the with-image patch df_readline contains 653 lines of > >code, of which only 303 are shared by the two modes. > > > >The largest block of shared code is the section (lines 3362-3465) > >checking for blank lines, skipped lines, and EOF. Is this even relevant > >to binary mode? > > > > That's correct. But my point is that they do pretty much similar > things, i.e., loading the variables to prepare the next stage of the > code that determines where to reroute them. Well, achieving the same goal is not the same thing as doing the same job, and thus doesn't call for having the two routines combined. I tend to agree with Ethan here: if they share so little actual code, they had better be in separate routines, and the common code broken out into a common subroutine. -- Hans-Bernhard Broeker (br...@ph...) Even if all the snow were burnt, ashes would remain. |