Menu
▾
▴
Re: GNUPLOT used in a new Android app
|
From: Alan L. <ala...@jh...> - 2026-06-20 19:59:47
|
Dear Ethan, thank you much for your response. I verified the cross-compilation process with the most recent Android NDK and the current development version 6.1 snapshot 20 June 2026. Really, the command.c patch with <sys/wait.h> turned out not to be necessary. So I updated my patch for the binaries distributed in the app accordingly, and deleted this modification. Cheers, Alan Am 2026-05-30 02:35, schrieb Ethan A Merritt: > On Monday, 25 May 2026 09:35:02 PDT Alan Liška via gnuplot-beta wrote: >> Dear gnuplot authors and contributors, >> >> I have published an open-source Android app (ChemKinDroid) which >> installer contains the gnuplot binaries cross-compiled for Android. > > I see no problem with the attribution or with copyright compliance. > > However I am curious about the need for a patch to source file > command.c. > In general we would like to understand the problem and fix the upstream > source so that a patch is not needed. > > Github shows > %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% > diff -ur gnuplot-6.0.3/src/command.c gnuplot_arm/src/command.c > --- gnuplot-6.0.3/src/command.c 2025-05-31 06:36:14.000000000 +0200 > +++ gnuplot_arm/src/command.c 2026-05-12 21:29:08.842121763 +0200 > @@ -56,6 +56,7 @@ > * input, and load_file() for non-interactive input. > */ > > +#include <sys/wait.h> > #include "command.h" > > #include "axis.h" > %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% > > Normally <sys/wait.h> should already have been included via syscfg.h as > a result > of the autoconfigure test AC_HEADER_SYS_WAIT. > Does this fail on Android? > Would the attached alternative patch to syscfg.h work instead? > If so I will make that change. > > My only other comment is that gnuplot 6.1 is the development version, > which means it is a moving target. Unlike the 6.0.x release versions. > Any bug report against the Adroid build will be more useful if it can > be traced to, e.g., "version 6.1 snapshot 25 May 2026" > or "version 6.1 commit c5fc5c1c22". > > cheers, > Ethan > >> The included docs contain these citations: >> >> ... >> * GNUPLOT >> Authors: Thomas Williams, Colin Kelley >> Ref.: Williams, T., Kelley, C., Bersch, C., Bröker, H.B., Campbell, >> J., >> Cunningham, R., Denholm, D., Elber, G., Fearick, R., Grammes, C. and >> Hart, L., 2023. gnuplot 6.1. >> Source code of the original version: >> https://urldefense.com/v3/__https://sourceforge.net/projects/gnuplot/__;!!K-Hz7m0Vt54!jfNFRsKf4HsbEnTZC_MQpmC4Z9dgcPfwcgQDacKcw9AHwvgCYOj3LVPCKE1pl9s5JztsVZK9V0ewXbnCf716gzNFloLo6XDpmZ4T$ >> Source code of the patch used for Android binaries used in this app: >> https://urldefense.com/v3/__https://github.com/alanliska/gnuplot-patch__;!!K-Hz7m0Vt54!jfNFRsKf4HsbEnTZC_MQpmC4Z9dgcPfwcgQDacKcw9AHwvgCYOj3LVPCKE1pl9s5JztsVZK9V0ewXbnCf716gzNFloLo6eKC6iE-$ >> License: open source, see the full license text under the Licenses >> button >> Copyright 1986 - 1993, 1998, 2004 Thomas Williams, Colin Kelley >> * >> * Permission to use, copy, and distribute this software and its >> * documentation for any purpose with or without fee is hereby >> granted, >> * provided that the above copyright notice appear in all copies and >> * that both that copyright notice and this permission notice appear >> * in supporting documentation. >> * >> * Permission to modify the software is granted, but not the right to >> * distribute the complete modified source code. Modifications are >> to >> * be distributed as patches to the released version. Permission to >> * distribute binaries produced by compiling modified sources is >> granted, >> * provided you >> * 1. distribute the corresponding source modifications from the >> * released version in the form of a patch file along with the >> binaries, >> * 2. add special version identification to distinguish your >> version >> * in addition to the base release version number, >> * 3. provide your name and address as the primary contact for the >> * support of your modified version, and >> * 4. retain our contact information in regard to use of the base >> * software. >> * Permission to distribute the released version of the source code >> along >> * with corresponding source modifications in the form of a patch >> file >> is >> * granted with same provisions 2 through 4 for binary distributions. >> * >> * This software is provided "as is" without express or implied >> warranty >> * to the extent permitted by applicable law. >> ... >> >> Sources of the pre-compiled binaries: >> * gnuplot: >> https://urldefense.com/v3/__https://sourceforge.net/projects/gnuplot/__;!!K-Hz7m0Vt54!jfNFRsKf4HsbEnTZC_MQpmC4Z9dgcPfwcgQDacKcw9AHwvgCYOj3LVPCKE1pl9s5JztsVZK9V0ewXbnCf716gzNFloLo6XDpmZ4T$ >> (official with >> custom patch) >> patch: >> https://urldefense.com/v3/__https://github.com/alanliska/gnuplot-patch__;!!K-Hz7m0Vt54!jfNFRsKf4HsbEnTZC_MQpmC4Z9dgcPfwcgQDacKcw9AHwvgCYOj3LVPCKE1pl9s5JztsVZK9V0ewXbnCf716gzNFloLo6eKC6iE-$ >> ... >> >> Is it sufficient? >> You can check it also in the source code of the app: >> https://urldefense.com/v3/__https://github.com/alanliska/ChemKinDroid__;!!K-Hz7m0Vt54!jfNFRsKf4HsbEnTZC_MQpmC4Z9dgcPfwcgQDacKcw9AHwvgCYOj3LVPCKE1pl9s5JztsVZK9V0ewXbnCf716gzNFloLo6b_AFNbx$ >> and in the patch itself: >> https://urldefense.com/v3/__https://github.com/alanliska/gnuplot-patch__;!!K-Hz7m0Vt54!jfNFRsKf4HsbEnTZC_MQpmC4Z9dgcPfwcgQDacKcw9AHwvgCYOj3LVPCKE1pl9s5JztsVZK9V0ewXbnCf716gzNFloLo6eKC6iE-$ >> >> Please let me know if you liked to add something more. >> Thank you in advance. >> >> Best regards, >> >> Alan Liška >> >> |
