NEW BUG: filled arrowheads not working

[Ethan M. <merritt@u.washington.edu>]

Did this just break recently?  I don't recall getting these errors before.

[1] rm term.o; make

gcc -DHAVE_CONFIG_H -I. -I. -I..  -I../term -I../term -DBINDIR=\"/usr/local/bin\" -DX11_DRIVER_DIR=\"/usr/local/libexec/gnuplot/3.8k\" -DCONTACT=\"gnu...@li...\" -DHELPFILE=\"/usr/local/share/gnuplot/3.8k/gnuplot.gih\" -I/usr/X11R6/include -I/usr/local/include   -g -O2 -Wall -c term.c
term.c: In function `do_arrow':
term.c:930: warning: comparison is always false due to limited range of data type
term.c:957: warning: comparison is always false due to limited range of data type
term.c:959: warning: comparison is always false due to limited range of data type
term.c:989: warning: comparison is always false due to limited range of data type
In file included from term.h:300,
                 from term.c:1054:
../term/fig.trm: In function `FIG_arrow':
../term/fig.trm:785: warning: comparison is always false due to limited range of data type
../term/fig.trm:807: warning: comparison is always false due to limited range of data type
../term/fig.trm:817: warning: comparison is always false due to limited range of data type


The problem is that curr_arrow_headfilled is a TBOOLEAN but then we find
code like the following in term.c:

	curr_arrow_headfilled = arrow_properties->head_filled
	...
	if (curr_arrow_headfilled == 2) {
		...

which tries to set it to an (int) and then test for values other than TRUE or FALSE.
The same problem arises elsewhere in term.c and in fig.trm
I tried the simple fix of changing curr_arrow_headfilled to be an int rather than
a TBOOLEAN, and similarly the last parameter to do_arrow(),
but this just made things worse (hundreds of incompatible pointer warnings).

Anyhow, the result is that filled arrowheads are not working.



-- 
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center    (206)543-1421
Mailstop 357742
University of Washington, Seattle, WA 98195