Re: 5.4.0: Mac OS X version available

[Ethan A M. <me...@uw...>]

On Wednesday, 23 September 2020 18:39:55 PDT Erik Luijten wrote:
> Dear Ethan et al.,
> 
> A Mac OS X package for version 5.4.0 is now available at
> https://csml-wiki.northwestern.edu/index.php/Binary_versions_of_Gnuplot_for_OS_X
> 
> If you encounter any problem, please let me know.
> 
> There is one small compilation issue that *seems* to be due to the way that
> src/Makefile is constructed. On the more recent versions of OS X, the X11
> libraries and header files are in /opt/X11, which ./configure does not
> detect. This is fine, since I can use the options '--x-include=/opt/X11/include
> --x-libraries=/opt/X11/lib' to specify this. However, the X11 library
> location does not get used in the compilation of gnuplot (only for
> gnuplot_x11, via the XLIBS variable), even though the main executable needs
> the Xpm library. Manually adding -L/opt/X11/lib to LDFLAGS in src/Makefile
> fixes this, but should not be necessary.
> 
> Regards,
> 
> Erik

Does the patch below fix it?

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
diff --git a/src/Makefile.am b/src/Makefile.am
index 0b261ea47..3a8b9b499 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -69,6 +69,7 @@ pkglibexec_PROGRAMS += gnuplot_x11
 gnuplot_x11_SOURCES = gplt_x11.c gplt_x11.h gpexecute.c gpexecute.h mousecmn.h version.c ver
sion.h
 XLIBS = @LIBRARIES_FOR_X@
 gnuplot_x11_LDADD = getcolor_x11.o $(XLIBS)
+gnuplot_LDADD += $(XLIBS)
 endif
 
 getcolor_x11.o: getcolor.c
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

	Ethan