Re: About your patch for qt5 for gnuplot for Cygwin

[Ethan A M. <sf...@us...>]

Is there a gnuplot bug assigned for this?

It seems very unusual to prefer a blocking socket to a non-blocking socket.

	Ethan

On Monday, March 4, 2019 2:37:48 PM PST Tatsuro MATSUOKA wrote:
> > From: Enrico Forestieri 
> 
> > To: Tatsuro MATSUOKA 
> > Cc: 
> > Date: 2018/3/12, Mon 17:17
> > Subject: Re: qt terminal on Cygwin
> > 
> > On Mon, Mar 12, 2018 at 10:27:31AM +0900, Tatsuro MATSUOKA wrote:
> > 
> >>  > You should simply avoid using O_NONBLOCK. Please, try the following 
> > patch:
> >> 
> >>  > 
> >>  > --- 
> > a/qtbase-everywhere-src-5.10.1/src/network/socket/qlocalsocket_unix.cpp
> >>  > +++ 
> > b/qtbase-everywhere-src-5.10.1/src/network/socket/qlocalsocket_unix.cpp
> >>  > @@ -239,7 +239,7 @@ void QLocalSocket::connectToServer(OpenM
> >>  >      }
> >>  > 
> >>  >      // create the socket
> >>  > -    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, 
> > SOCK_STREAM, 0, 
> >>  > O_NONBLOCK))) {
> >>  > +    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, 
> > SOCK_STREAM, 
> >>  > 0))) {
> >>  >          d->errorOccurred(UnsupportedSocketOperationError,
> >>  >                         
> >>  > QLatin1String("QLocalSocket::connectToServer"));
> >>  >          return;
> >>  > 
> >> 
> >>  Enrico
> >> 
> >>  What do you think about proposal of the above patch to cygwin list?
> >> 
> >>  If it's allowed, I will make a propasal to cygwin list.
> >>  (Of course I mention that patch is made by you.)
> > 
> > You can try, but I am not sure it will be accepted.
> 
> Dear Enrico
> 
> I proposed your patch about one year before and recently.
> For second proposal, I have gotten the reply qt maintainer on Cygwin.
> http://cygwin.1069669.n5.nabble.com/Patch-request-to-qt-5-9-4-Re-ANNOUNCEMENT-Qt-5-9-4-td144620.html
> 
> ************************************************
> > Dear Yaakov Selkowitz
> >
> > I ask alpply a patch the below which enables to use qt terminal on gnuplot for Cygwin.
> > (cygQt5Network-5.dll is affected.)
> >
> > --- a/qtbase-opensource-src-5.9.4/src/network/socket/qlocalsocket_unix.cpp
> > +++ b/qtbase-opensource-src-5.9.4/src/network/socket/qlocalsocket_unix.cpp
> > @@ -239,7 +239,7 @@ void QLocalSocket::connectToServer(OpenM
> >     }
> >     // create the socket
> > -    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, SOCK_STREAM, 0, O_NONBLOCK))) {
> > +    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, SOCK_STREAM, 0))) {
> >         d->errorOccurred(UnsupportedSocketOperationError,
> >                         QLatin1String("QLocalSocket::connectToServer"));
> >         return;
> >
> 
> It seems we keep going in circles on this point.  If there is a bug in
> O_NONBLOCK, then please either narrow it down to an STC, or provide a
> patch to Cygwin.
> 
> ************************************************
> 
> Can you do this or provide hint for me to rearch the answer?
> 
> Thank you in advance your kind consideration.
> 
> Tatsuro
> 
> 
> 
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> Membership management via: https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 


-- 
Ethan A Merritt
Biomolecular Structure Center,  K-428 Health Sciences Bldg
MS 357742,   University of Washington, Seattle 98195-7742