Re: Square aspect ratio doesn't work with very wide images and 'with rgbimage'

[Dima K. <gn...@di...>]

sfeam <me...@uw...> writes:

> Right now the code is
>
>   if (too-big)
> 	warn
>   else
> 	apply the correcion
>
> I suppose the alternative is to remove the "else". I.e. warn on the
> extreme case so that if there is a divide-by-zero or other bad outcome
> at least you have some hint as to what went wrong.
>
> Would you prefer that?

Maybe? The wide images that previously would be rejected appear to work
just fine after your patch (i.e. they're expectedly illegible, but you
can interactively zoom in as expected). So yeah. This logic probably is
what I favor (until we find something that breaks):

    if (too-big)
         warn
    do-the-thing;

Thanks much