|
From: Eric S. R. <es...@th...> - 2017-10-22 01:57:33
|
Daniel J Sebald <dan...@ie...>: > Oh, you are trying to add Author information that coincides with the > ChangeLog date. I was just thinking that CVS doesn't have an Author and > Committer date/time so whatever the CVS checkin time is becomes both those > date/times in git. > > If the date/time is the same, just add an hour (or tick), but of course if > there are more than two such date/times then one has to be careful to > continue checking. That is, we can't do > > Assume: > dt25 == dt26 == dt27 > > First comparison: > dt25 == dt26 > dt26++ > > Second comparison: > dt25 == dt27 > dt27++ > > because then dt26 and dt27 end up equal. > > Is there a situation if the commit time on a given day is 9:00 am and the > assigned author date is the same day 12:00 pm that the author date/time ends > up ahead of committer date/time? That would be odd. It's worse than you know. ChangeLog date stamps don't have a timezone. They are, presumably, in the local TZ of the author, but we don't know what that is. All of this has me about persuaded to switch action stamps to being based on commit times, which we always know to the second. I liked the author- based semantics better, but action stamps from imprecise dates creates too many collisions and special-case rules. > Ethan, et al. Would you be fine with the committer time and author time > always being the same? The ChangeLog entry date probably isn't real > accurate in itself, is it? *I* don't think this is a good idea. Throws away information that might be interesting. -- <a href="http://www.catb.org/~esr/">Eric S. Raymond</a> My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. |