Re: Aw: Re: News spin of repository conversion

[Daniel J S. <dan...@ie...>]

On 10/21/2017 02:53 PM, "Bastian Märkisch" wrote:
>>
>> Hence, what is really happening above is a search for the first author
>> line that comes at or after 'changeline'.  That's not correct.
>>
>>   From step 3, I think you meant to place the test of 'n' and
>> 'changeline' at the front of loop and 'break' (on >) instead.  I.e.,
>>
>>       if n > changeline:
>>           break
>>       if ',' in line:
>>           # Multiple attributions...ignore for now
>>           continue
>>       # Deal with some address masking
>>       line = line.replace(" <at> ", "@")
>>       space = line.find(" ")
>>       if space < 0:
>>           continue
>> ETC.
>>
>> It should break if "n > changeline", not if "n >= changeline", because
>> we want to include the scenario of author info at the first changed line
>> (which is the most typical scenario).
> 
> No quite the end of the story, though.  With that change I get 135
> "no time stamp matching" errors.

I see the code that checks the date and makes sure that the date is unique:

     if fdate in generated:
         continue

However, I don't understand the requirement that the date be unique. 
The only changes to be made for the changeset are Author and Email.  The 
more detailed information about the SHA, commiter, etc. remains the 
same.  Why the requirement?

Dan