Re: Aw: New spin of repository conversion

[Daniel J S. <dan...@ie...>]

On 10/18/2017 06:16 PM, Eric S. Raymond wrote:
> Daniel J Sebald <dan...@ie...>:
>> On 10/18/2017 03:25 PM, "Bastian Märkisch" wrote:
>>> Thank you for the new version.  Overall the attribution algorithm
>>> seems to work remarkably well! There are a number of cases though
>>> were it fails.
>>>
>>> Here's an example (picked more or less randomly):
>>> https://sourceforge.net/p/gnuplot/git-main/ci/26f769db9e954052b11dbc8f242fc35a3cfd6880/
>>> This one is attributed to Ethan, although the change is by me.
>>> The reason seems to be that the Changelog entry is inserted below
>>> an entry by Ethan on the same day.  I think that is not an uncommon
>>> case, in fact I quickly found around a dozen such cases.  Can this
>>> be taken into account or do we have to check manually?
>>
>> This why in the algorithm I wrote the search is backward from the first
>> change in ChangeLog.
>>
>> Dan
> 
> I don't know what you mean by "backward". "First" is topmost?

The utility is searching a file, so think of searching a diff hunk from 
the start of the file (text).  One of Peter's examples (redacted email 
addresses) below.  After the line "+++", look forward until finding the 
first line with a '+' in the first column.  Now, from that line search 
backward and we find Bastian as author, not Peter.  Peter is the first 
author in the modified file, but that isn't correct for this changeset:

sebald@ ~/gnuplot/test_repository/second_sourceforge/git-main $ git diff 
6b9ff30e7754e7fb07ac4f05d38a558b93ba7102 
63bc0f364a43d74ceca514a1954e2efa6c4ad7f6 --unified=10 ChangeLog
diff --git a/ChangeLog b/ChangeLog
index 4681d7f..35c39d8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,17 +1,22 @@
  2011-11-14  Peter Jjjjjj  <xxxxxx@xxxxxx>

         * src/plot2d.c (store2d_point): Fix for 4-column mode of
         BOXPLOT style which did not handle log scale correctly.

  2011-11-14  Bastian Mmmmmm  <xxxxxx@xxxxxx>

+       src/win.trm (WIN_set_color): Immediately translate palette color
+       values to RGB instead of passing them on. This makes it possible
+       to use more than one palettes in multiplots and in different
+       graph windows. Test e.g. with pm3dcolors.dem
+
         * src/win/wgraph.c src/win/wresourc.h src/win/wgnuplib.h: Add a
         separate switch to toggle antialiasing of polygons.

         * src/win/wgraph.c (Draw_XOR_Text): Implement a 10 year old FIXME:
         Use proper raster operation instead of double inversion.

  2011-11-12  Ssssss Tttttt  <xxxxxx@xxxxxx>

         * src/win/README.win-ja src/win/wgnuplot-ja.mnu: Update and sync
         with wgnuplot.mnu



Dan