|
From: Daniel J S. <dan...@ie...> - 2017-10-18 22:56:49
|
On 10/18/2017 05:08 PM, Juhász Péter wrote: > On Wed, 2017-10-18 at 13:58 -0400, Eric S. Raymond wrote: >> I've pushed a version including the 1.1 release in its tail, and all >> previously missing tags should now be visible. >> >> There are somewhere around 275 commits with empty comment fields. >> These should either have comments filled in or, if they are ChanegLog >> singletons that need to be glued to another clique, I need to know >> that. >> >> I've enclosed a file named EMPTY which is in the right format to be >> read back in by reposurgeon. All of you, please fill in any comments >> you can in the commits you're responsible for; if you want to clue me >> in to a ChangeLog commit that should be squashed with the previous >> one, put SQUASH in the comment field. Don't alter the divider lines. >> >> > > I've found a single instance of my name in the file, which incidentally > points to an edge case: I had modified the Changelog file itself > (fixing the date of the entry). Perhaps this warrants a SQUASH. Those are the tricky ones I noted previously: editing some date or something. My rule was that if only the ChangeLog changes, then the authorship would not be modified. It would remain as the committer. > I've also scanned through the commits attributed to me in the new git > repo, and I strongly suspect that some of those were not done by me. > E.g. 63bc0f364a43d74ceca514a1954e2efa6c4ad7f6, This one, by search-backward-from-first-change rule, would go to 2011-11-14 Bastian M <xxxxxx@xxxxxx> > dc3d0aa052b1af8563624f46516f27def76fdb80, and Same here, first change, searching backward points to 2011-11-14 Bastian M <xxxxxx@xxxxxx> > f2093b012b3b58842ae825439bfeec85b01fa8c3 Once again, searching backward from first change points to 2011-11-14 Bastian M <xxxxxx@xxxxxx> Dan are attributed to me but they > were obviously committed by Bastian Maerkisch. (So I confirm his > finding here). The reason indeed seems to be that unrelated changes by > the same author, on the same day were squashed in the Changelog, and > change-groups belonging to different authors, on the same day are > listed in arbitrary order, even though this confuses the actual order > of the changes. > > best regards, > Peter Juhasz |