|
From: Daniel J S. <dan...@ie...> - 2017-10-16 07:01:17
|
On 10/16/2017 01:32 AM, Bastian Märkisch wrote: > Dear Eric, dear Daniel, > > That sounds very promising! I am volunteering to inspect-by-eye (a subset) > of the new attributions (but have only limited time). > > One thing I like to point out is that in some cases the ChangeLog entry was > accidentally omitted (e.g. because the file changes were not saved). So it > might have turned up in the follw-up checkin, which now may lead to > incorrect attributions. Some may turn out correct. Some may have the authorship associated with the clean up, i.e., off by one or two but still close to the original modification. > Is it possible to check for such cases? Maybe for > inspection by eye? I know with the utility I wrote it could be modified pretty easily to indicate the changesets where the ChangeLog didn't change. It might be a pretty long list though. It seems to me, based on the little bit I saw, that near the start of the project there were long strings of mods and the the ChangeLog was updated. This may be where Eric's approach has an advantage, that rather than the diff hunk it sounds like he's pulling out the actual snapshot of the ChangeLog at the time the changeset was made. That might sweep some more changesets under the same author. Dan |