Re: swprintf_s in src/win32

[Allin C. <cot...@wf...>]

On Fri, 29 Sep 2017, Hans-Bernhard Bröker wrote:

> Am 29.09.2017 um 22:48 schrieb Allin Cottrell:
>
>> In current mingw64 built from source on Linux (x86_64-w64-mingw32 and 
>> i686-w64-mingw32) MINGW_HAS_SECURE_API is not defined in _mingw.h, or 
>> anywhere else, unless you choose --enable-secure-api at configure time 
>> (it's not enabled by default). Most software I've cross-built for Windows 
>> doesn't require sec_api so building wgnuplot is the first time I've come 
>> across this.
>
> Well, suffice it to say that the provided configuration in config/mingw is 
> explicitly designed for MSYS2 MinGW, which doesn't need that switch (and 
> would cause redefinition warnings if it was set).
>
> A cross-build from Linux is a completely separate kettle of fish.  There 
> would be a lot of other problems with that, starting with the lack of a Linux 
> edition of Microsoft's HTML Help Workshop...

It's easy enough to borrow a copy of wgnuplot.chm from a native 
Windows build, if one doesn't have the patience to get the HTML Help 
builder working under wine. Everything else works OK, modulo the MS 
"secure api" requirement (which is a relatively new thing, it wasn't 
an issue in years past).

All I'm suggesting is something like a note in config/mingw/Makefile 
saying you need to ensure that your mingw64 header build has 
enable-secure-api set. That would have saved me a fair amount of 
frustration.

Allin Cottrell