Re: swprintf_s in src/win32

[Allin C. <cot...@wf...>]

On Fri, 29 Sep 2017, Hans-Bernhard Bröker wrote:

> Am 29.09.2017 um 21:14 schrieb Allin Cottrell:
>> On Fri, 29 Sep 2017, Allin Cottrell wrote:
>
>>> My headers are also version 5.0.2 but I guess something must be wrong with 
>>> my setup; I'll investigate.
>> 
>> Ah, the build goes OK if I add -DMINGW_HAS_SECURE_API to CFLAGS. Maybe that 
>> information could be added in config/mingw?
>
> No, I don't think it should, since the program builds fine without it. I 
> check with both with the MinGW64 cross tools provided by Cygwin (that's 
> config/cygwin) and with MSYS2 MinGW64 (config/mingw).
>
> That switch is supposed to controlled by MinGW's own configuration header, 
> <_mingw.h>.

In current mingw64 built from source on Linux (x86_64-w64-mingw32 
and i686-w64-mingw32) MINGW_HAS_SECURE_API is not defined in 
_mingw.h, or anywhere else, unless you choose --enable-secure-api at 
configure time (it's not enabled by default). Most software I've 
cross-built for Windows doesn't require sec_api so building wgnuplot 
is the first time I've come across this.

I think it should be stated somewhere in config/mingw that you need 
to enable this (somewhow) to build wgnuplot. No harm done if one is 
using a pre-built mingw64 which already enables it.

Allin Cottrell