Re: Version 5.2 release candidate -rc3

[sfeam <sf...@us...>]

On Monday, 31 July 2017 08:12:05 Tatsuro MATSUOKA wrote:
> 
> ----- Original Message -----
> > From: sfeam via gnuplot-beta 
> > To: gnuplot-beta> Cc: 
> > Date: 2017/7/31, Mon 02:41
> > Subject: Version 5.2 release candidate -rc3
> > 
> > Source tarball for -rc3 in now in the "Release Candidates" folder on 
> > SourceForge.
> > 
> > I expect this will be the final release candidate.  
> > If nothing unexpected comes up we can put out version 5.2 itself later in 
> > August.
> > 
> > CHANGES SINCE rc2
> > =================
> > * NEW: revised "plot with table" can handle string-valued output 
> > columns
> > * CHANGE: revised pipe support on Windows when built with MinGW-64 or MSVC
> > * FIX: minor bugs in use of gnuplot variables by "fit" command
> > 
> >     Ethan
> 
> Directory pm3d is missing in 5.2-rc tar ball 

That is intentional.  So far as I know the scripts in the pm3d subdirectory are 
no longer needed because the operations they perform are now part of the main program.
The scripts can still be obtained from the SourceForge site if someone wants them.

> and make installer on windows build fails.

Can you figure out why it fails?  Is it because of these files

 .../config/mingw/Makefile
 .../config/msvc/Makefile

Does this patch fix it?

--- gnuplot52/config/mingw/Makefile	2017-07-30 09:44:01.450442197 -0700
+++ test52/config/mingw/Makefile	2017-07-30 18:01:58.078032167 -0700
@@ -1029,8 +1029,8 @@
 	-cp -p $(M)* $(DESTDIR)/demo/
 	mkdir -p $(DESTDIR)/demo/games
 	-cp -p $(M)/games/* $(DESTDIR)/demo/games/
-	mkdir -p $(DESTDIR)/contrib/pm3d/
-	-cp -p $(TOP)/pm3d/contrib/* $(DESTDIR)/contrib/pm3d/
+#	mkdir -p $(DESTDIR)/contrib/pm3d/
+#	-cp -p $(TOP)/pm3d/contrib/* $(DESTDIR)/contrib/pm3d/
 # docs
 	mkdir -p $(DESTDIR)/docs
 	-cp -p gnuplot.pdf $(DESTDIR)/docs/
--- gnuplot52/config/msvc/Makefile	2017-07-30 09:44:01.458441784 -0700
+++ test52/config/msvc/Makefile	2017-07-30 18:06:33.926299097 -0700
@@ -550,8 +550,8 @@
 	xcopy /Y $(TOP)\demo $(DESTDIR)\demo
 	if not exist $(DESTDIR)\demo\games mkdir $(DESTDIR)\demo\games
 	xcopy /Y $(TOP)\demo\games $(DESTDIR)\demo\games
-	if not exist $(DESTDIR)\contrib\pm3d mkdir $(DESTDIR)\contrib\pm3d
-	xcopy /Y $(TOP)\pm3d\contrib\*.* $(DESTDIR)\contrib\pm3d
+#	if not exist $(DESTDIR)\contrib\pm3d mkdir $(DESTDIR)\contrib\pm3d
+#	xcopy /Y $(TOP)\pm3d\contrib\*.* $(DESTDIR)\contrib\pm3d
 
 zip:
 	$(MAKE) DESTDIR=.\gnuplot install


> In 5.2 cvs source tree, directory pm3d exist and I copy it to the 5.2-rc source tree and execute make installer.
> 
> Please correct the 5.2-rc package.

If it is really needed for the program itself then I will restore the pm3d subdirectory.
But if the problem is only that the subdirectly is incorrectly listed in the Makefile
then let's fix that instead.

	thanks for testing

		Ethan

> Tatsuro