Aw: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

[Bastian M. <bma...@we...>]

> Gesendet: Donnerstag, 23. März 2017 um 02:58 Uhr
> Von: sfeam <sf...@us...>
>
> Aha!
> 
> Finally I understand how the position of GEPID in the enum could make a difference.
> It is because of these lines here:
> 
> QtGnuplotEvent.cpp: 123
> 
>              if ((type < 1000) || (type > GEDone))
>                         {
>                         // FIXME EAM - At this point the program cannot recover and
>                         // if we try to continue it will eventually become a zombie.
>                         // Better to just exit explicitly right now.
>                                 qDebug() << "qt_gnuplot exiting on read error";
>                                 exit(0);
>                                 // return;
>                         }
> 
> So it really does treat the event differently if the code comes after GEDone.
> Sigh.
> 
> OK, please revert my change to place GEPID at the end so that the
> Windows executables work properly.  That would break my debugging things
> on linux, but the windows code won't be run on linux anyhow.
> 
> I will think about how to make this more fool-proof and make sure that it
> does not break either linux or Windows in the future.
> 
> 
> Maybe it is a bit late to ask, but is the raise-console option really necessary
> on Windows?   In truth my preferred option would be to get rid of it, in which
> case GEPID is not needed anyhow.
> 
> 	Ethan
> 

Yes. raise-console is a must-have in my opinion. Personally, I use it all the time.
Also it works flawlessly on Windows for wgnuplot and console mode gnuplot in a cmd 
shell - at least for windows and wxt terminal, but also for qt on the systems I
tested it. But I am not opposed to allow "space" to be bound via "bind".

As I currently cannot reproduce the problem Tatsuro is seeing, it is a bit
more difficult to debug.  In particular, changing the order of definitions for
QEPID does not change anything here.  Weird.

  Bastian