Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)

[Tatsuro M. <tma...@ya...>]

----- Original Message -----

> From: sfeam 
> To: gnuplot-beta
> Cc: Tatsuro MATSUOKA <tmacchant3; bmaerkisch
> Date: 2017/3/23, Thu 10:58
> Subject: Re: qt terminal trouble 5.0.6 source on windows build (was Re: Release 5.0.6)
> 
> Aha!
> 
> Finally I understand how the position of GEPID in the enum could make a 
> difference.
> It is because of these lines here:
> 
> QtGnuplotEvent.cpp: 123
> 
>              if ((type < 1000) || (type > GEDone))
>                         {
>                         // FIXME EAM - At this point the program cannot recover 
> and
>                         // if we try to continue it will eventually become a 
> zombie.
>                         // Better to just exit explicitly right now.
>                                 qDebug() << "qt_gnuplot exiting on 
> read error";
>                                 exit(0);
>                                 // return;
>                         }
> 
> So it really does treat the event differently if the code comes after GEDone.
> Sigh.
> 
> OK, please revert my change to place GEPID at the end so that the
> Windows executables work properly.  That would break my debugging things
> on linux, but the windows code won't be run on linux anyhow.
> 
> I will think about how to make this more fool-proof and make sure that it
> does not break either linux or Windows in the future.
> 
> 
> Maybe it is a bit late to ask, but is the raise-console option really necessary
> on Windows?   In truth my preferred option would be to get rid of it, in which
> case GEPID is not needed anyhow.
> 
>     Ethan

Excuse me I have posted reply to the previous post before seeing this post.

> Maybe it is a bit late to ask, but is the raise-console option really necessary
> on Windows?   In truth my preferred option would be to get rid of it, in which
> case GEPID is not needed anyhow.

The raise-console option for qt for windows is implemented by Bastain.
Perhaps he will give you reply for this matter.

If I build binary using revert changes for QtGnuplotEvent.h, should I do the following
in Copyright?

 *   1. distribute the corresponding source modifications from the
 *    released version in the form of a patch file along with the binaries,
 *   2. add special version identification to distinguish your version
 *    in addition to the base release version number,
 *   3. provide your name and address as the primary contact for the
 *    support of your modified version, and
 *   4. retain our contact information in regard to use of the base
 *    software.

Tatsuro