Re: Changes to stable-5-0 branch

[Tatsuro M. <tma...@ya...>]

----- Original Message -----

> From: sfeam 
> To: gnuplot-beta
> Cc: Bastian Märkisch 
> Date: 2016/2/14, Sun 05:23
> Subject: Re: Changes to stable-5-0 branch
> 
> On Saturday, 13 February 2016 06:34:27 PM Bastian Märkisch wrote:
>>  Hi,
>> 
>>  Today I checked in some changes to the stable-5-0 branch which make 
>>  gnuplot sources compatible with MSYS2/Mingw-w64 on Windows, as well as 
>>  they make wxWidgets 3.0 work.  These changes should in principle be 
>>  compatible with other platforms, but I could only check on CentOS5 & 6.
>>  Of course it still compiles cleanly using MSVC2012 or the old MSYS/MinGW 
>>  combination, too.
> 
> In general it is not good to make changes in the stable branch that have not
> already been tested in the main branch (5.1).  Obviously there are exceptions
> like fixing a bug that is only present in the stable branch.
> 
> In particular the change below is problematic because it was already tried in
> the main branch and turned out to cause problems on some systems:
> 
>         * src/qtterminal/qt_term.h src/qtterminal/qt_conversion.cpp:  isnan()
>         is in namespace std.
> 

I have been used this isnan change for MinGW-w64 (both 32 and 64bit)
without any reports.

Tatsuro