Re: Please commit my post to the tickets (bug #1580, Feature Requests #415)

[Tatsuro M. <tma...@ya...>]

----- Original Message -----
> From: Ethan A Merritt 
> Cc: gnu...@li...; bma...@we...
> Date: 2015/3/24, Tue 12:52
> Subject: Re: Please commit my post to the tickets (bug #1580, Feature Requests #415)
> 
> On Tuesday, 24 March 2015 09:40:04 AM Tatsuro MATSUOKA wrote:
>>  Hello
>> 
>>  I have opened two ticket items.
>> 
>>  Improve utf-8 treatment in interactive session on gnuplot for windows
>> 
>>  http://sourceforge.net/p/gnuplot/feature-requests/415/
>> 
>> 
>>  pause -1 message is not correct for gnuplot.exe built by MinGW
>> 
>>  http://sourceforge.net/p/gnuplot/bugs/1580/
>> 
>> 
>>  If you have time I am happy for the commit the above.
> 
> Are you sure that this patch is OK?
> It always prings an extra "\n" because the commands following
> "if (buf)" are not inside { } brackets.
> 
> Was that intended?
> 
> %%%%%
> --- a/src/command.c     2015-02-16 01:39:20.000000000 +0900
> +++ b/src/command.c     2015-03-23 13:18:41.546081300 +0900
> @@ -1465,7 +1465,8 @@
> # if defined(WGP_CONSOLE) && defined(USE_MOUSE)
>         if (!paused_for_mouse || !MousableWindowOpened()) {
>             int junk = 0;
> -           if (buf) fprintf(stderr, "%s\n", buf);
> +           /* Use fputs instead of fprintf("%s\n",buf) to avoid 
> error in Message of Japanese Characters 
> in MinGW Compiler*/
> +           if (buf) fputs(buf, stderr);fputs("\n", stderr);
>             /* cannot use EAT_INPUT_WITH here */
>             do {
>                 junk = getch();
> %%%%%
> 
>     Ethan


I have forgotten to CC. to the list.

What you say is indeed right.

> +           if (buf) fputs(buf, stderr);fputs("\n", stderr);
is not correct.
> +           if (buf) { fputs(buf, stderr);fputs("\n", stderr);}
is correct

Regards

Tatsuro